Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2608)

Unified Diff: chrome/browser/page_load_metrics/page_load_tracker.cc

Issue 2851873002: Temporarily disable error detection for response_start. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/page_load_metrics/page_load_tracker.cc
diff --git a/chrome/browser/page_load_metrics/page_load_tracker.cc b/chrome/browser/page_load_metrics/page_load_tracker.cc
index 6aab07488e7f4bbe3fb32c3cd0de05d15c483923..4eea06ae233c6ff9d6aa4c28ff74d48c18be0bde 100644
--- a/chrome/browser/page_load_metrics/page_load_tracker.cc
+++ b/chrome/browser/page_load_metrics/page_load_tracker.cc
@@ -145,7 +145,14 @@ internal::PageLoadTimingStatus IsValidPageLoadTiming(
// crbug.com/590212.
LOG(ERROR) << "Invalid response_start " << timing.response_start
<< " for parse_start " << timing.parse_timing.parse_start;
- return internal::INVALID_ORDER_RESPONSE_START_PARSE_START;
+ // When browser-side navigation is enabled, we sometimes encounter this
+ // error case. For now, we disable reporting of this error, since most
+ // PageLoadMetricsObservers don't care about response_start and we want to
+ // see how much closer fixing this error will get us to page load metrics
+ // being consistent with and without browser side navigation enabled. See
+ // crbug.com/716587 for more details.
+ //
+ // return internal::INVALID_ORDER_RESPONSE_START_PARSE_START;
}
if (!EventsInOrder(timing.parse_timing.parse_start,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698