Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2851833002: Allow disk writes while checking webview version pref. (Closed)

Created:
3 years, 7 months ago by Torne
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Allow disk writes while checking webview version pref. Since N, the preference directory will be created if it doesn't exist when getSharedPreferences is called. Enable disk writes to prevent a strict mode violation; this will only happen the first time an app is started up. BUG=716219 Review-Url: https://codereview.chromium.org/2846963005 Cr-Commit-Position: refs/heads/master@{#468052} (cherry picked from commit fe20a56ce5c36f7a29880586d67ca5e82aea3756) Review-Url: https://codereview.chromium.org/2851833002 . Cr-Commit-Position: refs/branch-heads/3071@{#300} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/c5936af34a8293a610623e93e397e04725d3d51f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Torne
3 years, 7 months ago (2017-04-28 19:27:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c5936af34a8293a610623e93e397e04725d3d51f.

Powered by Google App Engine
This is Rietveld 408576698