Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2846963005: Allow disk writes while checking webview version pref. (Closed)

Created:
3 years, 7 months ago by Torne
Modified:
3 years, 7 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, android-webview-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow disk writes while checking webview version pref. Since N, the preference directory will be created if it doesn't exist when getSharedPreferences is called. Enable disk writes to prevent a strict mode violation; this will only happen the first time an app is started up. BUG=716219 Review-Url: https://codereview.chromium.org/2846963005 Cr-Commit-Position: refs/heads/master@{#468052} Committed: https://chromium.googlesource.com/chromium/src/+/fe20a56ce5c36f7a29880586d67ca5e82aea3756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumFactoryProvider.java View 2 chunks +10 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Torne
3 years, 7 months ago (2017-04-28 15:34:43 UTC) #2
sgurun-gerrit only
lgtm
3 years, 7 months ago (2017-04-28 17:11:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2846963005/1
3 years, 7 months ago (2017-04-28 17:32:50 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 17:55:42 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/fe20a56ce5c36f7a29880586d67c...

Powered by Google App Engine
This is Rietveld 408576698