Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2851723002: [turbofan] Rip out the unused OsrGuard node. (Closed)

Created:
3 years, 7 months ago by Jarin
Modified:
3 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Rip out the unused OsrGuard node. BUG=v8:6325 Review-Url: https://codereview.chromium.org/2851723002 Cr-Commit-Position: refs/heads/master@{#44974} Committed: https://chromium.googlesource.com/v8/v8/+/006240292e2b87fb41da04a685417d26f7a0ab0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -163 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +3 lines, -21 lines 0 comments Download
M src/compiler/bytecode-graph-builder.cc View 1 chunk +0 lines, -18 lines 0 comments Download
M src/compiler/common-operator.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/compiler/common-operator.cc View 2 chunks +0 lines, -28 lines 0 comments Download
M src/compiler/js-frame-specialization.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-frame-specialization.cc View 2 chunks +0 lines, -9 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/osr.cc View 3 chunks +1 line, -22 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Jarin
Could you take a look, please?
3 years, 7 months ago (2017-04-28 10:44:11 UTC) #2
Benedikt Meurer
LGTM!
3 years, 7 months ago (2017-04-28 10:46:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851723002/1
3 years, 7 months ago (2017-04-28 10:52:34 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 11:22:13 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/006240292e2b87fb41da04a685417d26f7a...

Powered by Google App Engine
This is Rietveld 408576698