Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Unified Diff: src/compiler/osr.cc

Issue 2851723002: [turbofan] Rip out the unused OsrGuard node. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/opcodes.h ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/osr.cc
diff --git a/src/compiler/osr.cc b/src/compiler/osr.cc
index ebf2c421b56e858cd2b1dc9865eefca853ddac16..2de3df63545f6ab4e1fa2adef5a7fdd80c3bd9ff 100644
--- a/src/compiler/osr.cc
+++ b/src/compiler/osr.cc
@@ -94,8 +94,7 @@ void PeelOuterLoopsForOsr(Graph* graph, CommonOperatorBuilder* common,
continue;
}
if (orig->InputCount() == 0 || orig->opcode() == IrOpcode::kParameter ||
- orig->opcode() == IrOpcode::kOsrValue ||
- orig->opcode() == IrOpcode::kOsrGuard) {
+ orig->opcode() == IrOpcode::kOsrValue) {
// No need to copy leaf nodes or parameters.
mapping->at(orig->id()) = orig;
continue;
@@ -254,20 +253,6 @@ void PeelOuterLoopsForOsr(Graph* graph, CommonOperatorBuilder* common,
}
}
-void SetTypeForOsrValue(Node* osr_value, Node* loop,
- CommonOperatorBuilder* common) {
- Node* osr_guard = nullptr;
- for (Node* use : osr_value->uses()) {
- if (use->opcode() == IrOpcode::kOsrGuard) {
- DCHECK_EQ(use->InputAt(0), osr_value);
- osr_guard = use;
- break;
- }
- }
-
- NodeProperties::ChangeOp(osr_guard, common->OsrGuard(OsrGuardType::kAny));
-}
-
} // namespace
void OsrHelper::Deconstruct(JSGraph* jsgraph, CommonOperatorBuilder* common,
@@ -297,12 +282,6 @@ void OsrHelper::Deconstruct(JSGraph* jsgraph, CommonOperatorBuilder* common,
CHECK(osr_loop); // Should have found the OSR loop.
- for (Node* use : osr_loop_entry->uses()) {
- if (use->opcode() == IrOpcode::kOsrValue) {
- SetTypeForOsrValue(use, osr_loop, common);
- }
- }
-
// Analyze the graph to determine how deeply nested the OSR loop is.
LoopTree* loop_tree = LoopFinder::BuildLoopTree(graph, tmp_zone);
« no previous file with comments | « src/compiler/opcodes.h ('k') | src/compiler/simplified-lowering.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698