Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2851673002: Switch SupportsUserData uses to use unique_ptr. (Closed)

Created:
3 years, 7 months ago by Avi (use Gerrit)
Modified:
3 years, 7 months ago
Reviewers:
michaelbai
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch SupportsUserData uses to use unique_ptr. The interface taking a raw pointer is deprecated and being removed. BUG=690937 Review-Url: https://codereview.chromium.org/2851673002 Cr-Commit-Position: refs/heads/master@{#468028} Committed: https://chromium.googlesource.com/chromium/src/+/ad784833978af52e8552372701aa759244cf9dff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -10 lines) Patch
M android_webview/browser/aw_contents_client_bridge_base.cc View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/browser/aw_login_delegate.cc View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/browser/aw_print_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M android_webview/browser/browser_view_renderer.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M android_webview/browser/net/aw_request_interceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/android_protocol_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M android_webview/native/aw_contents.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M android_webview/native/aw_settings.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Avi (use Gerrit)
3 years, 7 months ago (2017-04-28 05:08:52 UTC) #6
michaelbai
lgtm
3 years, 7 months ago (2017-04-28 16:15:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851673002/1
3 years, 7 months ago (2017-04-28 16:51:40 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 16:56:42 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ad784833978af52e8552372701aa...

Powered by Google App Engine
This is Rietveld 408576698