Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Unified Diff: android_webview/native/aw_contents.cc

Issue 2851673002: Switch SupportsUserData uses to use unique_ptr. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/native/android_protocol_handler.cc ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/native/aw_contents.cc
diff --git a/android_webview/native/aw_contents.cc b/android_webview/native/aw_contents.cc
index f357a4a9dcb3a43408061b085ffcd5b795f1933e..184c687884a66a519d0073a5b3700fda32360ff8 100644
--- a/android_webview/native/aw_contents.cc
+++ b/android_webview/native/aw_contents.cc
@@ -210,7 +210,7 @@ AwContents::AwContents(std::unique_ptr<WebContents> web_contents)
icon_helper_.reset(new IconHelper(web_contents_.get()));
icon_helper_->SetListener(this);
web_contents_->SetUserData(android_webview::kAwContentsUserDataKey,
- new AwContentsUserData(this));
+ base::MakeUnique<AwContentsUserData>(this));
browser_view_renderer_.RegisterWithWebContents(web_contents_.get());
CompositorID compositor_id;
@@ -1239,8 +1239,9 @@ AwRendererPriorityManager* AwContents::GetAwRendererPriorityManager() {
AwRendererPriorityManager* manager = static_cast<AwRendererPriorityManager*>(
rph->GetUserData(kComputedRendererPriorityUserDataKey));
if (manager == nullptr) {
+ manager = new AwRendererPriorityManager(rph);
rph->SetUserData(kComputedRendererPriorityUserDataKey,
- manager = new AwRendererPriorityManager(rph));
+ base::WrapUnique(manager));
}
return manager;
}
« no previous file with comments | « android_webview/native/android_protocol_handler.cc ('k') | android_webview/native/aw_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698