Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2851433002: 📺 Add supports_video_persistence back to ChromeTabbedActivity2. (Closed)

Created:
3 years, 7 months ago by PEConn
Modified:
3 years, 7 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

📺 Add supports_video_persistence back to ChromeTabbedActivity2. I think it was accidentally removed in https://codereview.chromium.org/2825133002. BUG= Review-Url: https://codereview.chromium.org/2851433002 Cr-Commit-Position: refs/heads/master@{#467628} Committed: https://chromium.googlesource.com/chromium/src/+/e3ff7043bfaebcdf27b03f4cbf2a28ea7ae83e83

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/android/java/AndroidManifest.xml View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
PEConn
Ultra simple - PTAL :-)
3 years, 7 months ago (2017-04-27 08:48:40 UTC) #2
Bernhard Bauer
LGTM, but dumb description nit: Can you hyphenate re-add or phrase it as "Add [...] ...
3 years, 7 months ago (2017-04-27 09:16:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851433002/1
3 years, 7 months ago (2017-04-27 09:24:58 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/e3ff7043bfaebcdf27b03f4cbf2a28ea7ae83e83
3 years, 7 months ago (2017-04-27 10:05:49 UTC) #10
mthiesse
3 years, 7 months ago (2017-04-27 12:34:33 UTC) #11
Message was sent while issue was closed.
Oops! Thanks for the fix. You'll want to merge this back to M-59 as well.

Powered by Google App Engine
This is Rietveld 408576698