Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2825133002: Ensure android:configChanges="uiMode" is handled for all ChromeActivitys (Closed)

Created:
3 years, 8 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
PEConn, gone
CC:
chromium-reviews, agrieve+watch_chromium.org, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Ensure android:configChanges="uiMode" is handled for all ChromeActivitys BUG=711713 Review-Url: https://codereview.chromium.org/2825133002 Cr-Commit-Position: refs/heads/master@{#465388} Committed: https://chromium.googlesource.com/chromium/src/+/3a7aacd3d5a42bf2f8271e66f4eecff5deae7535

Patch Set 1 #

Total comments: 4

Patch Set 2 : add newline #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -46 lines) Patch
M chrome/android/java/AndroidManifest.xml View 1 9 chunks +24 lines, -46 lines 1 comment Download

Messages

Total messages: 15 (7 generated)
mthiesse
PTAL. I've done some refactoring here to make future changes easier, can revert the refactoring ...
3 years, 8 months ago (2017-04-18 20:36:06 UTC) #2
gone
lgtm https://codereview.chromium.org/2825133002/diff/1/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/2825133002/diff/1/chrome/android/java/AndroidManifest.xml#newcode356 chrome/android/java/AndroidManifest.xml:356: android:hardwareAccelerated="false" {% endblock %} endblock on newline?
3 years, 8 months ago (2017-04-18 21:04:49 UTC) #4
mthiesse
https://codereview.chromium.org/2825133002/diff/1/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/2825133002/diff/1/chrome/android/java/AndroidManifest.xml#newcode356 chrome/android/java/AndroidManifest.xml:356: android:hardwareAccelerated="false" {% endblock %} On 2017/04/18 21:04:49, ping past ...
3 years, 8 months ago (2017-04-18 21:09:35 UTC) #5
gone
https://codereview.chromium.org/2825133002/diff/1/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/2825133002/diff/1/chrome/android/java/AndroidManifest.xml#newcode356 chrome/android/java/AndroidManifest.xml:356: android:hardwareAccelerated="false" {% endblock %} On 2017/04/18 21:09:35, mthiesse wrote: ...
3 years, 8 months ago (2017-04-18 21:13:54 UTC) #6
mthiesse
https://codereview.chromium.org/2825133002/diff/1/chrome/android/java/AndroidManifest.xml File chrome/android/java/AndroidManifest.xml (right): https://codereview.chromium.org/2825133002/diff/1/chrome/android/java/AndroidManifest.xml#newcode356 chrome/android/java/AndroidManifest.xml:356: android:hardwareAccelerated="false" {% endblock %} On 2017/04/18 21:13:54, ping past ...
3 years, 8 months ago (2017-04-18 21:16:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2825133002/20001
3 years, 8 months ago (2017-04-18 21:17:36 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/3a7aacd3d5a42bf2f8271e66f4eecff5deae7535
3 years, 8 months ago (2017-04-18 21:50:32 UTC) #13
PEConn
3 years, 7 months ago (2017-04-27 08:48:55 UTC) #15
Message was sent while issue was closed.
https://codereview.chromium.org/2825133002/diff/20001/chrome/android/java/And...
File chrome/android/java/AndroidManifest.xml (left):

https://codereview.chromium.org/2825133002/diff/20001/chrome/android/java/And...
chrome/android/java/AndroidManifest.xml:376: {{
self.supports_video_persistence() }}
I'm guessing you removed this line by accident? I'm adding it back in in
https://codereview.chromium.org/2851433002.

Powered by Google App Engine
This is Rietveld 408576698