Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Issue 2851303005: [Win10] Allow users to create start menu App shortcuts from chrome://apps. (Closed)

Created:
3 years, 7 months ago by calamity
Modified:
3 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Win10] Allow users to create start menu App shortcuts from chrome://apps. This CL re-enables the ability to create start menu shortcuts from the create shortcut view in chrome://apps which was disabled in Win8+ because Win8 shortcut creation doesn't work properly. Since things work again in Win10, just exclude Win8. BUG=717388 Review-Url: https://codereview.chromium.org/2851303005 Cr-Commit-Position: refs/heads/master@{#468901} Committed: https://chromium.googlesource.com/chromium/src/+/15c2e6536d2afc4cbc47204f13fd61c884cd57aa

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/ui/views/create_application_shortcut_view.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
calamity
+sky for OWNERS. PTAL, thanks!
3 years, 7 months ago (2017-05-02 05:16:32 UTC) #8
sky
LGTM
3 years, 7 months ago (2017-05-03 04:29:09 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851303005/40001
3 years, 7 months ago (2017-05-03 04:40:15 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 05:49:55 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/15c2e6536d2afc4cbc47204f13fd...

Powered by Google App Engine
This is Rietveld 408576698