Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 2851303005: [Win10] Allow users to create start menu App shortcuts from chrome://apps. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/create_application_shortcut_view.cc
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc
index fd2698cf9e0623a4eead510075dccb2123b53362..4ba140c45466db52959b12be872466dd85577d3c 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.cc
+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc
@@ -76,8 +76,10 @@ void CreateChromeApplicationShortcutView::InitControls() {
quick_launch_check_box_ = nullptr;
#if defined(OS_WIN)
+ base::win::Version version = base::win::GetVersion();
// Do not allow creating shortcuts on the Start Screen for Windows 8.
- if (base::win::GetVersion() < base::win::VERSION_WIN8) {
+ if (version != base::win::VERSION_WIN8 &&
+ version != base::win::VERSION_WIN8_1) {
menu_check_box_ = AddCheckbox(
l10n_util::GetStringUTF16(IDS_CREATE_SHORTCUTS_START_MENU_CHKBOX),
profile_->GetPrefs()->GetBoolean(prefs::kWebAppCreateInAppsMenu));
@@ -87,10 +89,10 @@ void CreateChromeApplicationShortcutView::InitControls() {
// that option from the dialog.
if (base::win::CanPinShortcutToTaskbar()) {
quick_launch_check_box_ = AddCheckbox(
- (base::win::GetVersion() >= base::win::VERSION_WIN7) ?
- l10n_util::GetStringUTF16(IDS_PIN_TO_TASKBAR_CHKBOX) :
- l10n_util::GetStringUTF16(
- IDS_CREATE_SHORTCUTS_QUICK_LAUNCH_BAR_CHKBOX),
+ (version >= base::win::VERSION_WIN7)
+ ? l10n_util::GetStringUTF16(IDS_PIN_TO_TASKBAR_CHKBOX)
+ : l10n_util::GetStringUTF16(
+ IDS_CREATE_SHORTCUTS_QUICK_LAUNCH_BAR_CHKBOX),
profile_->GetPrefs()->GetBoolean(prefs::kWebAppCreateInQuickLaunchBar));
}
#elif defined(OS_POSIX)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698