Reland of Enable HTTP/2 to use a LIFO scheduler to schedule write.

Reland of Enable HTTP/2 to use a LIFO scheduler to schedule write. (patchset #1 id:1 of https://codereview.chromium.org/2849983002/ )

Reason for revert:
net_unittests is still flaky. Reverting the revert.

Original issue's description:
> Revert of Enable HTTP/2 to use a LIFO scheduler to schedule write. (patchset #1 id:1 of https://codereview.chromium.org/2844963005/ )
> 
> Reason for revert:
> Reverting in hopes of fixing net_unittests. Specifically NSS/ClientCertStoreTest/0.CertAuthorityFiltering . See 716630.
> 
> Original issue's description:
> > Enable HTTP/2 to use a LIFO scheduler to schedule write.
> > 
> > This CL lands server change 152524616 by yasong.
> > 
> > BUG=488484
> > 
> > Review-Url: https://codereview.chromium.org/2844963005
> > Cr-Commit-Position: refs/heads/master@{#467971}
> > Committed: https://chromium.googlesource.com/chromium/src/+/c443c00c0c9e10b8ced1064d7da18c3a9668cac2
> 
> TBR=bnc@chromium.org,yasong@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=488484
> 
> Review-Url: https://codereview.chromium.org/2849983002
> Cr-Commit-Position: refs/heads/master@{#468165}
> Committed: https://chromium.googlesource.com/chromium/src/+/bc96e065ec4ed456aa427e5a3492c01e20f70dcf

TBR=bnc@chromium.org,yasong@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=488484

[sky, 2017-05-01 17:44:37]

The CQ bit was checked by sky@chromium.org

[sky, 2017-05-01 17:44:38]

Created Reland of Enable HTTP/2 to use a LIFO scheduler to schedule write.

[commit-bot: I haz the power, 2017-05-01 17:45:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Bence, 2017-05-01 17:46:00]

The CQ bit was unchecked by bnc@chromium.org

[Bence, 2017-05-01 17:46:46]

Thank you for relanding.

Turns out that this class is completely unused, so I actually prefer to remove
it: https://crrev.com/2852993002.

[Bence, 2017-05-01 17:47:18]

Description was changed from

==========
Reland of Enable HTTP/2 to use a LIFO scheduler to schedule write. (patchset #1
id:1 of https://codereview.chromium.org/2849983002/ )

Reason for revert:
net_unittests is still flaky. Reverting the revert.

Original issue's description:
> Revert of Enable HTTP/2 to use a LIFO scheduler to schedule write. (patchset
#1 id:1 of https://codereview.chromium.org/2844963005/ )
> 
> Reason for revert:
> Reverting in hopes of fixing net_unittests. Specifically
NSS/ClientCertStoreTest/0.CertAuthorityFiltering . See 716630.
> 
> Original issue's description:
> > Enable HTTP/2 to use a LIFO scheduler to schedule write.
> > 
> > This CL lands server change 152524616 by yasong.
> > 
> > BUG=488484
> > 
> > Review-Url: https://codereview.chromium.org/2844963005
> > Cr-Commit-Position: refs/heads/master@{#467971}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/c443c00c0c9e10b8ced1064d7da1...
> 
> TBR=bnc@chromium.org,yasong@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=488484
> 
> Review-Url: https://codereview.chromium.org/2849983002
> Cr-Commit-Position: refs/heads/master@{#468165}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bc96e065ec4ed456aa427e5a3492...

TBR=bnc@chromium.org,yasong@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=488484
==========

to

==========
Reland of Enable HTTP/2 to use a LIFO scheduler to schedule write. (patchset #1
id:1 of https://codereview.chromium.org/2849983002/ )

Reason for revert:
net_unittests is still flaky. Reverting the revert.

Original issue's description:
> Revert of Enable HTTP/2 to use a LIFO scheduler to schedule write. (patchset
#1 id:1 of https://codereview.chromium.org/2844963005/ )
> 
> Reason for revert:
> Reverting in hopes of fixing net_unittests. Specifically
NSS/ClientCertStoreTest/0.CertAuthorityFiltering . See 716630.
> 
> Original issue's description:
> > Enable HTTP/2 to use a LIFO scheduler to schedule write.
> > 
> > This CL lands server change 152524616 by yasong.
> > 
> > BUG=488484
> > 
> > Review-Url: https://codereview.chromium.org/2844963005
> > Cr-Commit-Position: refs/heads/master@{#467971}
> > Committed:
https://chromium.googlesource.com/chromium/src/+/c443c00c0c9e10b8ced1064d7da1...
> 
> TBR=bnc@chromium.org,yasong@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=488484
> 
> Review-Url: https://codereview.chromium.org/2849983002
> Cr-Commit-Position: refs/heads/master@{#468165}
> Committed:
https://chromium.googlesource.com/chromium/src/+/bc96e065ec4ed456aa427e5a3492...

TBR=bnc@chromium.org,yasong@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=488484
==========

[sky, 2017-05-01 21:00:06]

I'm glad I could help locate unused code:)

On Mon, May 1, 2017 at 10:46 AM, <bnc@chromium.org> wrote:

> Thank you for relanding.
>
> Turns out that this class is completely unused, so I actually prefer to
> remove
> it: https://crrev.com/2852993002.
>
> https://codereview.chromium.org/2851273002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.