Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2844963005: Enable HTTP/2 to use a LIFO scheduler to schedule write. (Closed)

Created:
3 years, 7 months ago by yasong
Modified:
3 years, 7 months ago
Reviewers:
Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable HTTP/2 to use a LIFO scheduler to schedule write. This CL lands server change 152524616 by yasong. BUG=488484 Review-Url: https://codereview.chromium.org/2844963005 Cr-Commit-Position: refs/heads/master@{#467971} Committed: https://chromium.googlesource.com/chromium/src/+/c443c00c0c9e10b8ced1064d7da18c3a9668cac2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -10 lines) Patch
M net/spdy/core/lifo_write_scheduler.h View 4 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/core/lifo_write_scheduler_test.cc View 2 chunks +9 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
yasong
On 2017/04/28 12:36:17, yasong wrote: > mailto:yasong@chromium.org changed reviewers: > + mailto:bnc@chromium.org Ready for review. ...
3 years, 7 months ago (2017-04-28 12:36:30 UTC) #7
Bence
LGTM, thank you.
3 years, 7 months ago (2017-04-28 12:49:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844963005/1
3 years, 7 months ago (2017-04-28 12:49:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c443c00c0c9e10b8ced1064d7da18c3a9668cac2
3 years, 7 months ago (2017-04-28 12:54:33 UTC) #13
findit-for-me
Findit(https://goo.gl/kROfz5) identified this CL at revision 467971 as the culprit for failures in the build ...
3 years, 7 months ago (2017-04-28 16:07:42 UTC) #14
sky
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2849983002/ by sky@chromium.org. ...
3 years, 7 months ago (2017-04-28 22:46:41 UTC) #15
sky
3 years, 7 months ago (2017-04-29 15:16:30 UTC) #16
Message was sent while issue was closed.
On 2017/04/28 22:46:41, sky wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2849983002/ by mailto:sky@chromium.org.
> 
> The reason for reverting is: Reverting in hopes of fixing net_unittests.
> Specifically NSS/ClientCertStoreTest/0.CertAuthorityFiltering . See 716630..

This appears to have been the culprit as the last 20 or so runs looks good on
the two linux bots that were failing.

Powered by Google App Engine
This is Rietveld 408576698