Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2849983002: Revert of Enable HTTP/2 to use a LIFO scheduler to schedule write. (Closed)

Created:
3 years, 7 months ago by sky
Modified:
3 years, 7 months ago
Reviewers:
yasong, Bence
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable HTTP/2 to use a LIFO scheduler to schedule write. (patchset #1 id:1 of https://codereview.chromium.org/2844963005/ ) Reason for revert: Reverting in hopes of fixing net_unittests. Specifically NSS/ClientCertStoreTest/0.CertAuthorityFiltering . See 716630. Original issue's description: > Enable HTTP/2 to use a LIFO scheduler to schedule write. > > This CL lands server change 152524616 by yasong. > > BUG=488484 > > Review-Url: https://codereview.chromium.org/2844963005 > Cr-Commit-Position: refs/heads/master@{#467971} > Committed: https://chromium.googlesource.com/chromium/src/+/c443c00c0c9e10b8ced1064d7da18c3a9668cac2 TBR=bnc@chromium.org,yasong@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488484 Review-Url: https://codereview.chromium.org/2849983002 Cr-Commit-Position: refs/heads/master@{#468165} Committed: https://chromium.googlesource.com/chromium/src/+/bc96e065ec4ed456aa427e5a3492c01e20f70dcf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M net/spdy/core/lifo_write_scheduler.h View 4 chunks +4 lines, -4 lines 0 comments Download
M net/spdy/core/lifo_write_scheduler_test.cc View 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
sky
Created Revert of Enable HTTP/2 to use a LIFO scheduler to schedule write.
3 years, 7 months ago (2017-04-28 22:46:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849983002/1
3 years, 7 months ago (2017-04-28 22:47:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/bc96e065ec4ed456aa427e5a3492c01e20f70dcf
3 years, 7 months ago (2017-04-28 22:47:54 UTC) #6
sky
3 years, 7 months ago (2017-05-01 17:44:37 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2851273002/ by sky@chromium.org.

The reason for reverting is: net_unittests is still flaky. Reverting the
revert..

Powered by Google App Engine
This is Rietveld 408576698