Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 2851223003: Fix appinstalled event firing when user opens a WebAPK from banner. (Closed)

Created:
3 years, 7 months ago by Matt Giuca
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix appinstalled event firing when user opens a WebAPK from banner. The "Open" button was calling SendBannerAccepted, which made the assumption that the app was being installed. Removed this call and documented the method's semantics. BUG=716313 Review-Url: https://codereview.chromium.org/2848703005 Cr-Commit-Position: refs/heads/master@{#467903} (cherry picked from commit d398f548f1929bf2a8307d02bc69065cd7cdc035) Review-Url: https://codereview.chromium.org/2851223003 . Cr-Commit-Position: refs/branch-heads/3071@{#339} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/68c2976343b37ebe1568ccc566fe8c72ab74a795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/android/banners/app_banner_infobar_delegate_android.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/android/banners/app_banner_infobar_delegate_android.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Matt Giuca
3 years, 7 months ago (2017-05-02 04:06:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68c2976343b37ebe1568ccc566fe8c72ab74a795.

Powered by Google App Engine
This is Rietveld 408576698