Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 2851223002: Revert of WebVR: fix focus while presenting (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
klausw, bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of WebVR: fix focus while presenting (patchset #1 id:1 of https://codereview.chromium.org/2847233002/ ) Reason for revert: So there are a bunch of problems with this CL. 1. Now third-party iframes can just arbitrarily read head pose without needing focus as long as the main page has focus. 2. We've just broken the assumption that only one VrDisplay can be focused at a time. If the page has two iframes that want poses, and one presents, they're now both going to be fighting with each other to get the pose information. Original issue's description: > WebVR: fix focus while presenting > > If the WebVR document loses focus, check if the new focused element is an > embedding local parent frame. If that's the case, continue presenting. This > fixes issues with Cardboard-style touch events that are reported as a click at > viewport (0, 0) where the resulting focus loss stopped presentation. > > BUG=710863 > > Review-Url: https://codereview.chromium.org/2847233002 > Cr-Commit-Position: refs/heads/master@{#468140} > Committed: https://chromium.googlesource.com/chromium/src/+/984c8d18acf4b891d5bf39db6a898e2187340e0f TBR=bajones@chromium.org,klausw@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=710863 Review-Url: https://codereview.chromium.org/2851223002 Cr-Commit-Position: refs/heads/master@{#468349} Committed: https://chromium.googlesource.com/chromium/src/+/b85de8ac470aef12f8d666b881cd9888a8b2e645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -36 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 3 chunks +2 lines, -35 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mthiesse
Created Revert of WebVR: fix focus while presenting
3 years, 7 months ago (2017-05-01 15:41:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851223002/1
3 years, 7 months ago (2017-05-01 15:41:56 UTC) #3
klausw
On 2017/05/01 15:41:29, mthiesse wrote: > Created Revert of WebVR: fix focus while presenting LGTM
3 years, 7 months ago (2017-05-01 17:16:13 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 17:40:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b85de8ac470aef12f8d666b881cd...

Powered by Google App Engine
This is Rietveld 408576698