Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2847233002: WebVR: fix focus while presenting (Closed)

Created:
3 years, 7 months ago by klausw
Modified:
3 years, 7 months ago
Reviewers:
mthiesse, bajones
CC:
chromium-reviews, haraken, blink-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WebVR: fix focus while presenting If the WebVR document loses focus, check if the new focused element is an embedding local parent frame. If that's the case, continue presenting. This fixes issues with Cardboard-style touch events that are reported as a click at viewport (0, 0) where the resulting focus loss stopped presentation. BUG=710863 Review-Url: https://codereview.chromium.org/2847233002 Cr-Commit-Position: refs/heads/master@{#468140} Committed: https://chromium.googlesource.com/chromium/src/+/984c8d18acf4b891d5bf39db6a898e2187340e0f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -2 lines) Patch
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 3 chunks +35 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
klausw
(Extracted from https://codereview.chromium.org/2848483003/ )
3 years, 7 months ago (2017-04-28 18:45:57 UTC) #2
bajones
On 2017/04/28 18:45:57, klausw wrote: > (Extracted from https://codereview.chromium.org/2848483003/ ) LGTM
3 years, 7 months ago (2017-04-28 20:19:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2847233002/1
3 years, 7 months ago (2017-04-28 21:36:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/984c8d18acf4b891d5bf39db6a898e2187340e0f
3 years, 7 months ago (2017-04-28 21:42:42 UTC) #12
mthiesse
3 years, 7 months ago (2017-05-01 15:41:29 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2851223002/ by mthiesse@chromium.org.

The reason for reverting is: So there are a bunch of problems with this CL.

1. Now third-party iframes can just arbitrarily read head pose without needing
focus as long as the main page has focus.

2. We've just broken the assumption that only one VrDisplay can be focused at a
time. If the page has two iframes that want poses, and one presents, they're now
both going to be fighting with each other to get the pose information..

Powered by Google App Engine
This is Rietveld 408576698