[CrOS Tether] Add the HasConnectedToHost network field to NetworkStateHandler.

[CrOS Tether] Add the HasConnectedToHost network field to NetworkStateHandler.

Currently, "false" is always passed as this parameter, but the parameter is properly utilized as part of a follow-up CL: https://codereview.chromium.org/2852693004/.

BUG=672263
Review-Url: https://codereview.chromium.org/2850993002
Cr-Commit-Position: refs/heads/master@{#468390}
Committed: https://chromium.googlesource.com/chromium/src/+/92916a4d9532477e190e08454189fcfdde08eb1c

[Kyle Horimoto, 2017-04-29 00:05:09]

khorimoto@chromium.org changed reviewers:
+ stevenjb@chromium.org

[stevenjb, 2017-05-01 16:11:31]

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_handler.cc (right):

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:557: << "not currently registered.
Cannot update.";
nit: Very long messages like this in the log are a bit hard to read. The
file+line context is also provided, so I tend to prefer simpler messages, e.g.
"Update Tether Properties: No NetworkState for: " << GUID

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:574: << "network which is not
registered. GUID: " << guid;
ditto

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:582: }
if (tether_network_state->tether_has_connected_to_host())
  return false;

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.h:230: // Updates the whether the Tether
network with GUID |guid| has connected to
s/the whether/whether/

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.h:239: // AddTetherNetworkState(). If no
network with GUI |guid| is registered, this
s/GUI/GUID/ or 'id' or just 'with |guid|'

[Kyle Horimoto, 2017-05-01 16:56:27]

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_handler.cc (right):

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:557: << "not currently registered.
Cannot update.";
On 2017/05/01 16:11:31, stevenjb wrote:
> nit: Very long messages like this in the log are a bit hard to read. The
> file+line context is also provided, so I tend to prefer simpler messages, e.g.
> "Update Tether Properties: No NetworkState for: " << GUID
> 

Done.

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:574: << "network which is not
registered. GUID: " << guid;
On 2017/05/01 16:11:31, stevenjb wrote:
> ditto

Done.

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.cc:582: }
On 2017/05/01 16:11:31, stevenjb wrote:
> if (tether_network_state->tether_has_connected_to_host())
>   return false;

Done.

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
File chromeos/network/network_state_handler.h (right):

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.h:230: // Updates the whether the Tether
network with GUID |guid| has connected to
On 2017/05/01 16:11:31, stevenjb wrote:
> s/the whether/whether/

Done.

https://codereview.chromium.org/2850993002/diff/1/chromeos/network/network_st...
chromeos/network/network_state_handler.h:239: // AddTetherNetworkState(). If no
network with GUI |guid| is registered, this
On 2017/05/01 16:11:31, stevenjb wrote:
> s/GUI/GUID/ or 'id' or just 'with |guid|'
> 
> 

Done.

[stevenjb, 2017-05-01 17:33:04]

lgtm

[Kyle Horimoto, 2017-05-01 17:33:35]

The CQ bit was checked by khorimoto@chromium.org

[commit-bot: I haz the power, 2017-05-01 17:34:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 19:50:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493660015389550,
"parent_rev": "39d1ffe7ba2c6fc8ebe6245472e0191b6f29aa9c", "commit_rev":
"92916a4d9532477e190e08454189fcfdde08eb1c"}

[commit-bot: I haz the power, 2017-05-01 19:50:20]

Description was changed from

==========
[CrOS Tether] Add the HasConnectedToHost network field to NetworkStateHandler.

Currently, "false" is always passed as this parameter, but the parameter is
properly utilized as part of a follow-up CL:
https://codereview.chromium.org/2852693004/.

BUG=672263
==========

to

==========
[CrOS Tether] Add the HasConnectedToHost network field to NetworkStateHandler.

Currently, "false" is always passed as this parameter, but the parameter is
properly utilized as part of a follow-up CL:
https://codereview.chromium.org/2852693004/.

BUG=672263

Review-Url: https://codereview.chromium.org/2850993002
Cr-Commit-Position: refs/heads/master@{#468390}
Committed:
https://chromium.googlesource.com/chromium/src/+/92916a4d9532477e190e08454189...
==========

[commit-bot: I haz the power, 2017-05-01 19:50:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/92916a4d9532477e190e08454189...