Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4901)

Unified Diff: chrome/test/data/extensions/api_test/networking_private/chromeos/test.js

Issue 2850993002: [CrOS Tether] Add the HasConnectedToHost network field to NetworkStateHandler. (Closed)
Patch Set: stevenjb@ comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
diff --git a/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js b/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
index f39c1eefed52ef79d0521a47527e42da0572043e..388390dd53bf0cae6f36e707462163e369155eaa 100644
--- a/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
+++ b/chrome/test/data/extensions/api_test/networking_private/chromeos/test.js
@@ -84,7 +84,7 @@ var privateHelpers = {
},
verifyTetherNetwork: function(
properties, expectedGuid, expectedName, expectedBatteryPercentage,
- expectedCarrier, expectedSignalStrength) {
+ expectedCarrier, expectedSignalStrength, expectedHasConnectedToHost) {
//assertEq(NetworkType.Tether, properties.Type);
assertEq(expectedGuid, properties.GUID);
assertEq(expectedName,
@@ -92,9 +92,7 @@ var privateHelpers = {
: properties.Name);
assertEq(expectedBatteryPercentage, properties.Tether.BatteryPercentage);
assertEq(expectedCarrier, properties.Tether.Carrier);
- // TODO(khorimoto): Add the expected value as a parameter once it can be set
- // via the Tether component.
- assertFalse(properties.Tether.HasConnectedToHost);
+ assertEq(expectedHasConnectedToHost, properties.Tether.HasConnectedToHost);
assertEq(expectedSignalStrength, properties.Tether.SignalStrength);
}
};
@@ -944,9 +942,9 @@ var availableTests = [
callbackPass(function(tetherNetworks) {
assertEq(2, tetherNetworks.length);
privateHelpers.verifyTetherNetwork(tetherNetworks[0], 'tetherGuid1',
- 'tetherName1', 50, 'tetherCarrier1', 75);
+ 'tetherName1', 50, 'tetherCarrier1', 75, true);
privateHelpers.verifyTetherNetwork(tetherNetworks[1], 'tetherGuid2',
- 'tetherName2', 75, 'tetherCarrier2', 100);
+ 'tetherName2', 75, 'tetherCarrier2', 100, false);
}));
},
function getTetherNetworkProperties() {
@@ -954,7 +952,7 @@ var availableTests = [
'tetherGuid1',
callbackPass(function(tetherNetwork) {
privateHelpers.verifyTetherNetwork(tetherNetwork, 'tetherGuid1',
- 'tetherName1', 50, 'tetherCarrier1', 75);
+ 'tetherName1', 50, 'tetherCarrier1', 75, true);
}));
},
function getTetherNetworkManagedProperties() {
@@ -962,7 +960,7 @@ var availableTests = [
'tetherGuid1',
callbackPass(function(tetherNetwork) {
privateHelpers.verifyTetherNetwork(tetherNetwork, 'tetherGuid1',
- 'tetherName1', 50, 'tetherCarrier1', 75);
+ 'tetherName1', 50, 'tetherCarrier1', 75, true);
}));
},
function getTetherNetworkState() {
@@ -970,7 +968,7 @@ var availableTests = [
'tetherGuid1',
callbackPass(function(tetherNetwork) {
privateHelpers.verifyTetherNetwork(tetherNetwork, 'tetherGuid1',
- 'tetherName1', 50, 'tetherCarrier1', 75);
+ 'tetherName1', 50, 'tetherCarrier1', 75, true);
}));
},
];

Powered by Google App Engine
This is Rietveld 408576698