Add a nullptr check in blink::RequestCallbacks::onSuccess to fix crash.

Add a nullptr check in blink::RequestCallbacks::onSuccess to fix crash.

Apparently the crash is happening in blink::Document::GetFrame() because Document* is NULL.

BUG=706294
Review-Url: https://codereview.chromium.org/2850813004
Cr-Commit-Position: refs/heads/master@{#468952}
Committed: https://chromium.googlesource.com/chromium/src/+/656ba920a74cb5e83d65712d1f97b3cdde335197

[vasilii, 2017-04-28 16:20:52]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 16:21:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[vasilii, 2017-04-28 16:21:23]

vasilii@chromium.org changed reviewers:
+ mkwst@chromium.org

[vasilii, 2017-04-28 16:21:23]

Hi Mike,

please review.

[commit-bot: I haz the power, 2017-04-28 17:59:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 17:59:23]

Dry run: This issue passed the CQ dry run.

[Mike West, 2017-05-02 07:07:28]

Code change LGTM. Can you add a test that verifies the behavior?

[vasilii, 2017-05-02 16:05:24]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[vasilii, 2017-05-02 16:05:38]

please review again.

[commit-bot: I haz the power, 2017-05-02 16:06:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 16:10:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 16:10:47]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[vasilii, 2017-05-02 16:55:50]

The CQ bit was checked by vasilii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 16:56:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 19:10:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 19:10:13]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2017-05-03 07:54:31]

Thanks for adding the test. LGTM once the ASAN bot is happy.

https://codereview.chromium.org/2850813004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
(right):

https://codereview.chromium.org/2850813004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp:95:
return;
I think we need to call `resolver_->Clear()` in this case. That might make the
ASAN bot happier.

[vasilii, 2017-05-03 09:05:20]

https://codereview.chromium.org/2850813004/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp
(right):

https://codereview.chromium.org/2850813004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.cpp:95:
return;
On 2017/05/03 07:54:31, Mike West wrote:
> I think we need to call `resolver_->Clear()` in this case. That might make the
> ASAN bot happier.

there is no such a method.

[vasilii, 2017-05-03 10:46:10]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2017-05-03 10:46:10]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2850813004/#ps60001
(title: "fix the test")

[commit-bot: I haz the power, 2017-05-03 10:46:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 10:49:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 10:49:14]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vasilii, 2017-05-03 11:20:14]

The CQ bit was checked by vasilii@chromium.org

[vasilii, 2017-05-03 11:20:14]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2850813004/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2017-05-03 11:20:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 13:08:45]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493810414268770,
"parent_rev": "a4a1c9f941ec3f46f796bfc20fc378c976b632c1", "commit_rev":
"656ba920a74cb5e83d65712d1f97b3cdde335197"}

[commit-bot: I haz the power, 2017-05-03 13:08:52]

Description was changed from

==========
Add a nullptr check in blink::RequestCallbacks::onSuccess to fix crash.

Apparently the crash is happening in blink::Document::GetFrame() because
Document* is NULL.

BUG=706294
==========

to

==========
Add a nullptr check in blink::RequestCallbacks::onSuccess to fix crash.

Apparently the crash is happening in blink::Document::GetFrame() because
Document* is NULL.

BUG=706294

Review-Url: https://codereview.chromium.org/2850813004
Cr-Commit-Position: refs/heads/master@{#468952}
Committed:
https://chromium.googlesource.com/chromium/src/+/656ba920a74cb5e83d65712d1f97...
==========

[commit-bot: I haz the power, 2017-05-03 13:08:55]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/656ba920a74cb5e83d65712d1f97...