Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: third_party/WebKit/Source/modules/credentialmanager/CredentialsContainer.h

Issue 2850813004: Add a nullptr check in blink::RequestCallbacks::onSuccess to fix crash. (Closed)
Patch Set: rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CredentialsContainer_h 5 #ifndef CredentialsContainer_h
6 #define CredentialsContainer_h 6 #define CredentialsContainer_h
7 7
8 #include "modules/ModulesExport.h"
8 #include "platform/bindings/ScriptWrappable.h" 9 #include "platform/bindings/ScriptWrappable.h"
9 #include "platform/heap/Handle.h" 10 #include "platform/heap/Handle.h"
10 11
11 namespace blink { 12 namespace blink {
12 13
13 class Credential; 14 class Credential;
14 class CredentialRequestOptions; 15 class CredentialRequestOptions;
15 class ScriptPromise; 16 class ScriptPromise;
16 class ScriptState; 17 class ScriptState;
17 18
18 class CredentialsContainer final 19 class MODULES_EXPORT CredentialsContainer final
19 : public GarbageCollected<CredentialsContainer>, 20 : public GarbageCollected<CredentialsContainer>,
20 public ScriptWrappable { 21 public ScriptWrappable {
21 DEFINE_WRAPPERTYPEINFO(); 22 DEFINE_WRAPPERTYPEINFO();
22 23
23 public: 24 public:
24 static CredentialsContainer* Create(); 25 static CredentialsContainer* Create();
25 26
26 // CredentialsContainer.h 27 // CredentialsContainer.h
27 ScriptPromise get(ScriptState*, const CredentialRequestOptions&); 28 ScriptPromise get(ScriptState*, const CredentialRequestOptions&);
28 ScriptPromise store(ScriptState*, Credential* = 0); 29 ScriptPromise store(ScriptState*, Credential* = 0);
29 ScriptPromise requireUserMediation(ScriptState*); 30 ScriptPromise requireUserMediation(ScriptState*);
30 31
31 DEFINE_INLINE_VIRTUAL_TRACE() {} 32 DEFINE_INLINE_VIRTUAL_TRACE() {}
32 33
33 private: 34 private:
34 CredentialsContainer(); 35 CredentialsContainer();
35 }; 36 };
36 37
37 } // namespace blink 38 } // namespace blink
38 39
39 #endif // CredentialsContainer_h 40 #endif // CredentialsContainer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698