MD Bookmarks: Update Delete command to only delete the minimal set of nodes

MD Bookmarks: Update Delete command to only delete the minimal set of nodes

This adds a filter so that when asking to delete a node at the same time
as one of its children, only the parent node will be explicitly deleted
(the child node will be implicitly deleted).

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2850763002
Cr-Commit-Position: refs/heads/master@{#469612}
Committed: https://chromium.googlesource.com/chromium/src/+/f1ffc8932b93b6dca10055638cb08460f4752fed

[tsergeant, 2017-04-28 06:28:57]

Description was changed from

==========
MD Bookmarks: Update Delete command to only delete the minimal set of nodes

This adds a filter so that when asking to delete a node at the same time
as one of its children, only the parent node will be explicitly deleted
(the child node will be implicitly deleted).

BUG=692827
==========

to

==========
MD Bookmarks: Update Delete command to only delete the minimal set of nodes

This adds a filter so that when asking to delete a node at the same time
as one of its children, only the parent node will be explicitly deleted
(the child node will be implicitly deleted).

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-04-28 06:29:47]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 06:29:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 06:46:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 06:46:11]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[tsergeant, 2017-05-05 05:23:27]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 05:23:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-05-05 05:24:50]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[calamity, 2017-05-05 06:20:41]

lgtm

https://codereview.chromium.org/2850763002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/command_manager.js (right):

https://codereview.chromium.org/2850763002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.js:120: * a node and its
descendant, we will only try to delete the topmost node.
Mention why this is necessary.

https://codereview.chromium.org/2850763002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.js:130: var currentId =
assert(nodes[currentId].parentId);
nit: extra var.

[commit-bot: I haz the power, 2017-05-05 06:24:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 06:24:13]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2017-05-05 06:38:56]

https://codereview.chromium.org/2850763002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_bookmarks/command_manager.js (right):

https://codereview.chromium.org/2850763002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.js:120: * a node and its
descendant, we will only try to delete the topmost node.
On 2017/05/05 06:20:41, calamity wrote:
> Mention why this is necessary.

Done.

https://codereview.chromium.org/2850763002/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_bookmarks/command_manager.js:130: var currentId =
assert(nodes[currentId].parentId);
On 2017/05/05 06:20:41, calamity wrote:
> nit: extra var.

oops

[tsergeant, 2017-05-05 06:39:03]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2017-05-05 06:39:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2850763002/#ps40001
(title: "Review comments")

[commit-bot: I haz the power, 2017-05-05 06:39:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 07:43:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493966343965440,
"parent_rev": "e147d68dc40b1470b6de6c2d8f9232bd788e897e", "commit_rev":
"f1ffc8932b93b6dca10055638cb08460f4752fed"}

[commit-bot: I haz the power, 2017-05-05 07:44:00]

Description was changed from

==========
MD Bookmarks: Update Delete command to only delete the minimal set of nodes

This adds a filter so that when asking to delete a node at the same time
as one of its children, only the parent node will be explicitly deleted
(the child node will be implicitly deleted).

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Bookmarks: Update Delete command to only delete the minimal set of nodes

This adds a filter so that when asking to delete a node at the same time
as one of its children, only the parent node will be explicitly deleted
(the child node will be implicitly deleted).

BUG=692827
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2850763002
Cr-Commit-Position: refs/heads/master@{#469612}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1ffc8932b93b6dca10055638cb0...
==========

[commit-bot: I haz the power, 2017-05-05 07:44:01]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f1ffc8932b93b6dca10055638cb0...