Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/test/data/webui/md_bookmarks/command_manager_test.js

Issue 2850763002: MD Bookmarks: Update Delete command to only delete the minimal set of nodes (Closed)
Patch Set: Review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/md_bookmarks/command_manager.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/md_bookmarks/command_manager_test.js
diff --git a/chrome/test/data/webui/md_bookmarks/command_manager_test.js b/chrome/test/data/webui/md_bookmarks/command_manager_test.js
index 07e414cbabcd682f5cc9384ab45a058d23e290de..c0b993b10b610861bd39a54401e8f121f881077f 100644
--- a/chrome/test/data/webui/md_bookmarks/command_manager_test.js
+++ b/chrome/test/data/webui/md_bookmarks/command_manager_test.js
@@ -25,13 +25,19 @@ suite('<bookmarks-command-manager>', function() {
setup(function() {
store = new bookmarks.TestStore({
- nodes: testTree(createFolder(
- '1',
- [
- createFolder('11', []),
- createFolder('12', []),
- createItem('13'),
- ])),
+ nodes: testTree(
+ createFolder(
+ '1',
+ [
+ createFolder(
+ '11',
+ [
+ createItem('111'),
+ ]),
+ createFolder('12', []),
+ createItem('13'),
+ ]),
+ createFolder('2', [])),
});
bookmarks.Store.instance_ = store;
@@ -111,4 +117,17 @@ suite('<bookmarks-command-manager>', function() {
MockInteractions.pressAndReleaseKeyOn(document, keyCode, '', key);
assertLastCommand('edit', ['11']);
});
+
+ test('does not delete children at same time as ancestor', function() {
+ var lastDelete = null;
+ chrome.bookmarkManagerPrivate.removeTrees = function(idArray) {
+ lastDelete = idArray.sort();
+ };
+
+ var parentAndChildren = new Set(['1', '2', '12', '111']);
+ assertTrue(commandManager.canExecute(Command.DELETE, parentAndChildren));
+ commandManager.handle(Command.DELETE, parentAndChildren);
+
+ assertDeepEquals(['1', '2'], lastDelete);
+ });
});
« no previous file with comments | « chrome/browser/resources/md_bookmarks/command_manager.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698