Replace ServiceInfo with BindSourceInfo.

Replace ServiceInfo with BindSourceInfo.

ServiceInfo used to carry manifest capability data. We don't need to pass this to clients now that enforcement is done in the service manager, so I'd like to remove it before anyone discovers they can use it for something odd.

. Service.mojom:OnStart now takes an identity, since we don't need any additional metadata during startup.
. Service.mojom:OnBindInterface now takes a new struct BindSourceInfo. This is the remote identity + an array of capability names. This array is populated with the names of all the capabilities that the remote requires of the target. The target can use this to modify behavior based on the presence of one of these bits. No one uses this yet except for the service manager itself (e.g. all_users, client_process, etc.)

R=tsepez@chromium.org,rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2850743004
Cr-Commit-Position: refs/heads/master@{#468553}
Committed: https://chromium.googlesource.com/chromium/src/+/2c36828dfc0bef3e7792bdd6e13fdb199b5d97fd

[Ben Goodger (Google), 2017-04-28 23:33:12]

Description was changed from

==========
Replace ServiceInfo with BindSourceInfo.

ServiceInfo used to carry manifest capability data. We don't need to pass this
to clients now that enforcement is done in the service manager, so I'd like to
remove it before anyone discovers they can use it for something odd.

. Service.mojom:OnStart now takes an identity, since we don't need any
additional metadata during startup.
. Service.mojom:OnBindInterface now takes a new struct BindSourceInfo. This is
the remote identity + an array of capability names. This array is populated with
the names of all the capabilities that the remote requires of the target. The
target can use this to modify behavior based on the presence of one of these
bits. No one uses this yet except for the service manager itself (e.g.
all_users, client_process, etc.)

R=tsepez@chromium.org,rockot@chromium.org
==========

to

==========
Replace ServiceInfo with BindSourceInfo.

ServiceInfo used to carry manifest capability data. We don't need to pass this
to clients now that enforcement is done in the service manager, so I'd like to
remove it before anyone discovers they can use it for something odd.

. Service.mojom:OnStart now takes an identity, since we don't need any
additional metadata during startup.
. Service.mojom:OnBindInterface now takes a new struct BindSourceInfo. This is
the remote identity + an array of capability names. This array is populated with
the names of all the capabilities that the remote requires of the target. The
target can use this to modify behavior based on the presence of one of these
bits. No one uses this yet except for the service manager itself (e.g.
all_users, client_process, etc.)

R=tsepez@chromium.org,rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Ben Goodger (Google), 2017-04-28 23:33:12]

Description was changed from

==========
Replace ServiceInfo with BindSourceInfo.

ServiceInfo used to carry manifest capability data. We don't need to pass this
to clients now that enforcement is done in the service manager, so I'd like to
remove it before anyone discovers they can use it for something odd.

. Service.mojom:OnStart now takes an identity, since we don't need any
additional metadata during startup.
. Service.mojom:OnBindInterface now takes a new struct BindSourceInfo. This is
the remote identity + an array of capability names. This array is populated with
the names of all the capabilities that the remote requires of the target. The
target can use this to modify behavior based on the presence of one of these
bits. No one uses this yet except for the service manager itself (e.g.
all_users, client_process, etc.)

R=tsepez@chromium.org,rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Replace ServiceInfo with BindSourceInfo.

ServiceInfo used to carry manifest capability data. We don't need to pass this
to clients now that enforcement is done in the service manager, so I'd like to
remove it before anyone discovers they can use it for something odd.

. Service.mojom:OnStart now takes an identity, since we don't need any
additional metadata during startup.
. Service.mojom:OnBindInterface now takes a new struct BindSourceInfo. This is
the remote identity + an array of capability names. This array is populated with
the names of all the capabilities that the remote requires of the target. The
target can use this to modify behavior based on the presence of one of these
bits. No one uses this yet except for the service manager itself (e.g.
all_users, client_process, etc.)

R=tsepez@chromium.org,rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[Ben Goodger (Google), 2017-04-28 23:33:18]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 23:34:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 23:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 23:45:10]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Ben Goodger (Google), 2017-04-28 23:59:01]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 23:59:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 00:10:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 00:10:04]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Ben Goodger (Google), 2017-04-29 02:34:16]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 02:34:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 02:45:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 02:45:51]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2017-04-29 04:34:24]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 04:34:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 04:44:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 04:44:24]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2017-04-29 05:04:11]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 05:04:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 05:13:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 05:13:50]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2017-05-01 16:02:53]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 16:03:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Rockot(use gerrit already), 2017-05-01 16:07:59]

lgtm

[Ben Goodger (Google), 2017-05-01 16:10:55]

The CQ bit was checked by ben@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 16:11:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 16:25:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 16:25:28]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Tom Sepez, 2017-05-01 17:09:37]

lgtm

[Ben Goodger (Google), 2017-05-01 17:09:58]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-05-01 17:09:58]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2850743004/#ps100001
(title: ".")

[commit-bot: I haz the power, 2017-05-01 17:10:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 17:10:30]

This CL has an open dependency (Issue 2847743003 Patch 320001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[Ben Goodger (Google), 2017-05-01 23:49:57]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2017-05-01 23:50:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 00:00:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 00:00:47]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2017-05-02 01:41:12]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-05-02 01:41:13]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2850743004/#ps120001
(title: ".")

[commit-bot: I haz the power, 2017-05-02 01:41:47]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 01:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 01:52:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Ben Goodger (Google), 2017-05-02 02:10:58]

The CQ bit was checked by ben@chromium.org

[Ben Goodger (Google), 2017-05-02 02:10:59]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2850743004/#ps140001
(title: ".")

[commit-bot: I haz the power, 2017-05-02 02:11:34]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 02:47:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 02:47:41]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Ben Goodger (Google), 2017-05-02 03:03:25]

The CQ bit was checked by ben@chromium.org

[commit-bot: I haz the power, 2017-05-02 03:03:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 04:09:04]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1493694205487780,
"parent_rev": "183d5a9be5ecd0321996d17e84e6352a96113ee5", "commit_rev":
"2c36828dfc0bef3e7792bdd6e13fdb199b5d97fd"}

[commit-bot: I haz the power, 2017-05-02 04:10:34]

Description was changed from

==========
Replace ServiceInfo with BindSourceInfo.

ServiceInfo used to carry manifest capability data. We don't need to pass this
to clients now that enforcement is done in the service manager, so I'd like to
remove it before anyone discovers they can use it for something odd.

. Service.mojom:OnStart now takes an identity, since we don't need any
additional metadata during startup.
. Service.mojom:OnBindInterface now takes a new struct BindSourceInfo. This is
the remote identity + an array of capability names. This array is populated with
the names of all the capabilities that the remote requires of the target. The
target can use this to modify behavior based on the presence of one of these
bits. No one uses this yet except for the service manager itself (e.g.
all_users, client_process, etc.)

R=tsepez@chromium.org,rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Replace ServiceInfo with BindSourceInfo.

ServiceInfo used to carry manifest capability data. We don't need to pass this
to clients now that enforcement is done in the service manager, so I'd like to
remove it before anyone discovers they can use it for something odd.

. Service.mojom:OnStart now takes an identity, since we don't need any
additional metadata during startup.
. Service.mojom:OnBindInterface now takes a new struct BindSourceInfo. This is
the remote identity + an array of capability names. This array is populated with
the names of all the capabilities that the remote requires of the target. The
target can use this to modify behavior based on the presence of one of these
bits. No one uses this yet except for the service manager itself (e.g.
all_users, client_process, etc.)

R=tsepez@chromium.org,rockot@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2850743004
Cr-Commit-Position: refs/heads/master@{#468553}
Committed:
https://chromium.googlesource.com/chromium/src/+/2c36828dfc0bef3e7792bdd6e13f...
==========

[commit-bot: I haz the power, 2017-05-02 04:10:35]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/2c36828dfc0bef3e7792bdd6e13f...