Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Unified Diff: content/browser/frame_host/render_frame_host_impl.cc

Issue 2850743004: Replace ServiceInfo with BindSourceInfo. (Closed)
Patch Set: . Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/gpu/gpu_process_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_host_impl.cc
diff --git a/content/browser/frame_host/render_frame_host_impl.cc b/content/browser/frame_host/render_frame_host_impl.cc
index 24c8b1582aaff6acc720839dced9ce3ee35ee1c4..26ad1d9b3d595f18519cf1121f0d1914a0f8c6be 100644
--- a/content/browser/frame_host/render_frame_host_impl.cc
+++ b/content/browser/frame_host/render_frame_host_impl.cc
@@ -1689,15 +1689,6 @@ void RenderFrameHostImpl::DisableSwapOutTimerForTesting() {
swapout_event_monitor_timeout_.reset();
}
-void RenderFrameHostImpl::OnRendererConnect(
- const service_manager::ServiceInfo& local_info,
- const service_manager::ServiceInfo& remote_info) {
- if (remote_info.identity.name() != mojom::kRendererServiceName)
- return;
- browser_info_ = local_info;
- renderer_info_ = remote_info;
-}
-
void RenderFrameHostImpl::OnContextMenu(const ContextMenuParams& params) {
if (!is_active())
return;
@@ -3087,17 +3078,6 @@ void RenderFrameHostImpl::SetUpMojoIfNeeded() {
static_cast<AssociatedInterfaceRegistry*>(associated_registry_.get())
->AddInterface(base::Bind(make_binding, base::Unretained(this)));
- ServiceManagerConnection* service_manager_connection =
- BrowserContext::GetServiceManagerConnectionFor(
- GetProcess()->GetBrowserContext());
- // |service_manager_connection| may not be set in unit tests using
- // TestBrowserContext.
- if (service_manager_connection) {
- on_connect_handler_id_ = service_manager_connection->AddOnConnectHandler(
- base::Bind(&RenderFrameHostImpl::OnRendererConnect,
- weak_ptr_factory_.GetWeakPtr()));
- }
-
RegisterMojoInterfaces();
mojom::FrameFactoryPtr frame_factory;
BindInterface(GetProcess(), &frame_factory);
@@ -3116,15 +3096,6 @@ void RenderFrameHostImpl::SetUpMojoIfNeeded() {
void RenderFrameHostImpl::InvalidateMojoConnection() {
interface_registry_.reset();
- ServiceManagerConnection* service_manager_connection =
- BrowserContext::GetServiceManagerConnectionFor(
- GetProcess()->GetBrowserContext());
- // |service_manager_connection| may be null in tests using TestBrowserContext.
- if (service_manager_connection) {
- service_manager_connection->RemoveOnConnectHandler(on_connect_handler_id_);
- on_connect_handler_id_ = 0;
- }
-
frame_.reset();
frame_host_interface_broker_binding_.Close();
frame_bindings_control_.reset();
« no previous file with comments | « content/browser/frame_host/render_frame_host_impl.h ('k') | content/browser/gpu/gpu_process_host.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698