[USS] implement CreateMetadataChangeList and GetClientTag

[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

BUG=708275
Review-Url: https://codereview.chromium.org/2850633004
Cr-Commit-Position: refs/heads/master@{#470491}
Committed: https://chromium.googlesource.com/chromium/src/+/d5a746320e0b79e86e7531efd8d668b352ec0400

[Gang Wu, 2017-04-28 21:01:56]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 21:03:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gang Wu, 2017-04-28 21:06:32]

Description was changed from

==========
fix


change interface level

BUG=
==========

to

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

And also revert https://codereview.chromium.org/2841653003/, which put
interface at database level. 
In this CL, I put the interface at backend level, instead of at
database level, since history should not expose database to outside.

BUG=708275
==========

[Gang Wu, 2017-04-28 21:06:32]

gangwu@chromium.org changed reviewers:
+ pavely@chromium.org

[Gang Wu, 2017-04-28 21:08:46]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 21:09:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gang Wu, 2017-04-28 21:10:17]

Patchset #1 (id:1) has been deleted

[Gang Wu, 2017-04-28 21:11:09]

Description was changed from

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

And also revert https://codereview.chromium.org/2841653003/, which put
interface at database level. 
In this CL, I put the interface at backend level, instead of at
database level, since history should not expose database to outside.

BUG=708275
==========

to

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

And also revert https://codereview.chromium.org/2841653003/, which put
interface at database level. 
In this CL, I put the interface at backend level, instead of at
database level, since HistoryBackend should not expose database to outside.

BUG=708275
==========

[Gang Wu, 2017-04-28 21:26:28]

Hi Pavel, PTAL

[commit-bot: I haz the power, 2017-04-28 22:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 22:18:57]

Dry run: This issue passed the CQ dry run.

[pavely, 2017-05-01 17:24:16]

https://codereview.chromium.org/2850633004/diff/20001/components/history/core...
File components/history/core/browser/history_backend.h (right):

https://codereview.chromium.org/2850633004/diff/20001/components/history/core...
components/history/core/browser/history_backend.h:104: public
syncer::SyncMetadataStore {
I don't really like exposing SyncMetadataStore to consumers of HistoryBackend.
What if instead we passed pointer to SyncMetadataStore into constructor of
TypedURLSyncBridge? We instantiate bridge in HistoryBackend::Init where we can
get the reference to HistoryDatabase.

[Gang Wu, 2017-05-01 18:24:03]

Description was changed from

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

And also revert https://codereview.chromium.org/2841653003/, which put
interface at database level. 
In this CL, I put the interface at backend level, instead of at
database level, since HistoryBackend should not expose database to outside.

BUG=708275
==========

to

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

Hooked up TypedURLSyncBridge and TypedURLSyncMetadataDatabase.

BUG=708275
==========

[Gang Wu, 2017-05-01 18:31:22]

Patchset #2 (id:40001) has been deleted

[Gang Wu, 2017-05-01 18:33:32]

Patchset #2 (id:60001) has been deleted

[Gang Wu, 2017-05-01 18:34:11]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 18:35:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Gang Wu, 2017-05-01 18:48:04]

Description was changed from

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

Hooked up TypedURLSyncBridge and TypedURLSyncMetadataDatabase.

BUG=708275
==========

to

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

BUG=708275
==========

[Gang Wu, 2017-05-01 18:48:30]

updated.

[pavely, 2017-05-01 18:58:21]

lgtm

https://codereview.chromium.org/2850633004/diff/80001/components/history/core...
File components/history/core/browser/typed_url_sync_bridge.h (right):

https://codereview.chromium.org/2850633004/diff/80001/components/history/core...
components/history/core/browser/typed_url_sync_bridge.h:24:
syncer::SyncMetadataStore* sync_metadata_store);
nit: Could you move history_backend and sync_metadata_store parameters together
since they are related.

[Gang Wu, 2017-05-01 19:10:22]

gangwu@chromium.org changed reviewers:
+ brettw@chromium.org

[Gang Wu, 2017-05-01 19:10:22]

Hi Brett, PTAL

https://codereview.chromium.org/2850633004/diff/80001/components/history/core...
File components/history/core/browser/typed_url_sync_bridge.h (right):

https://codereview.chromium.org/2850633004/diff/80001/components/history/core...
components/history/core/browser/typed_url_sync_bridge.h:24:
syncer::SyncMetadataStore* sync_metadata_store);
On 2017/05/01 18:58:21, pavely wrote:
> nit: Could you move history_backend and sync_metadata_store parameters
together
> since they are related.

Done.

[Gang Wu, 2017-05-01 19:10:37]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 19:11:21]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 20:59:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 20:59:32]

Dry run: This issue passed the CQ dry run.

[brettw, 2017-05-09 19:32:14]

lgtm

https://codereview.chromium.org/2850633004/diff/100001/components/history/cor...
File components/history/core/browser/typed_url_sync_bridge.h (right):

https://codereview.chromium.org/2850633004/diff/100001/components/history/cor...
components/history/core/browser/typed_url_sync_bridge.h:23:
syncer::SyncMetadataStore* sync_metadata_store,
Can you add a comment here that the sync_metadata_store object must outlive this
class?

https://codereview.chromium.org/2850633004/diff/100001/components/history/cor...
components/history/core/browser/typed_url_sync_bridge.h:59: // The database for
storing typed urls sync metadata and state.
Can you comment here that this is a non-owning pointer?

[Gang Wu, 2017-05-09 21:16:09]

The CQ bit was checked by gangwu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 21:18:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 21:48:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 21:48:43]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Gang Wu, 2017-05-10 05:45:08]

https://codereview.chromium.org/2850633004/diff/100001/components/history/cor...
File components/history/core/browser/typed_url_sync_bridge.h (right):

https://codereview.chromium.org/2850633004/diff/100001/components/history/cor...
components/history/core/browser/typed_url_sync_bridge.h:23:
syncer::SyncMetadataStore* sync_metadata_store,
On 2017/05/09 19:32:13, brettw (behind--catching up) wrote:
> Can you add a comment here that the sync_metadata_store object must outlive
this
> class?

Done.

https://codereview.chromium.org/2850633004/diff/100001/components/history/cor...
components/history/core/browser/typed_url_sync_bridge.h:59: // The database for
storing typed urls sync metadata and state.
On 2017/05/09 19:32:13, brettw (behind--catching up) wrote:
> Can you comment here that this is a non-owning pointer?

Done.

[Gang Wu, 2017-05-10 05:45:15]

The CQ bit was checked by gangwu@chromium.org

[Gang Wu, 2017-05-10 05:45:15]

The patchset sent to the CQ was uploaded after l-g-t-m from pavely@chromium.org,
brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/2850633004/#ps120001
(title: "comments")

[commit-bot: I haz the power, 2017-05-10 05:46:30]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 05:55:09]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1494395115408460,
"parent_rev": "91088a195969f5af61f404c9f02edc622cbe373a", "commit_rev":
"d5a746320e0b79e86e7531efd8d668b352ec0400"}

[commit-bot: I haz the power, 2017-05-10 05:55:25]

Description was changed from

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

BUG=708275
==========

to

==========
[USS] implement CreateMetadataChangeList and GetClientTag

Implement two functions in TypedURLSyncBridge, CreateMetadataChangeList
and GetClientTag.

BUG=708275

Review-Url: https://codereview.chromium.org/2850633004
Cr-Commit-Position: refs/heads/master@{#470491}
Committed:
https://chromium.googlesource.com/chromium/src/+/d5a746320e0b79e86e7531efd8d6...
==========

[commit-bot: I haz the power, 2017-05-10 05:55:29]

Committed patchset #4 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/d5a746320e0b79e86e7531efd8d6...