Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2841653003: [USS] TypedURLSyncMetadataDatabase inherits SyncMetadataStores (Closed)

Created:
3 years, 8 months ago by Gang Wu
Modified:
3 years, 8 months ago
Reviewers:
brettw, pavely
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[USS] TypedURLSyncMetadataDatabase inherits SyncMetadataStore BUG=708275 This is a follow up for CL https://codereview.chromium.org/2794413002/. It allows typed urls to use common implementation of MetadataChangeList (SyncMetadataStoreChangeList) instead of implementing its own. Review-Url: https://codereview.chromium.org/2841653003 Cr-Commit-Position: refs/heads/master@{#467193} Committed: https://chromium.googlesource.com/chromium/src/+/e92abbd14ad37670120e1c38ecf2cf6ce1a7eecd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -24 lines) Patch
M components/history/core/browser/typed_url_sync_metadata_database.h View 2 chunks +13 lines, -15 lines 0 comments Download
M components/history/core/browser/typed_url_sync_metadata_database.cc View 3 chunks +15 lines, -1 line 0 comments Download
M components/history/core/browser/typed_url_sync_metadata_database_unittest.cc View 4 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 25 (19 generated)
Gang Wu
PTAL
3 years, 8 months ago (2017-04-24 18:29:33 UTC) #3
pavely
lgtm. Could you add description explaining that this change is a step towards making TypedUrlSyncBridge ...
3 years, 8 months ago (2017-04-25 17:23:53 UTC) #14
Gang Wu
Hi Brett, PTAL
3 years, 8 months ago (2017-04-25 17:31:09 UTC) #19
brettw
lgtm
3 years, 8 months ago (2017-04-25 22:40:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841653003/20001
3 years, 8 months ago (2017-04-25 23:48:22 UTC) #22
commit-bot: I haz the power
3 years, 8 months ago (2017-04-26 01:20:10 UTC) #25
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e92abbd14ad37670120e1c38ecf2...

Powered by Google App Engine
This is Rietveld 408576698