Rename LayoutTable::CollapseBorders() to ShouldCollapseBorders()

Rename LayoutTable::CollapseBorders() to ShouldCollapseBorders()

The method returns true if the table has "border-collapse: collapse"
style. A better name could be CollapsesBorders() to reflect its
purpose, but both this name and the original name are easily confusing
with another method "CollapsedBorders()".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2850633003
Cr-Commit-Position: refs/heads/master@{#468443}
Committed: https://chromium.googlesource.com/chromium/src/+/05f315fbcdb64a90b96d4fee27741100e2bcdbb4

[Xianzhu, 2017-04-28 17:03:39]

Description was changed from

==========
Rename LayoutTable::CollapseBorders() to ShouldCollapseBorders()

The method returns true if the table has "border-collapse: collapse"
style. A better name could be CollapsesBorders() to reflect its
purpose, but both this name and the original name are easily confusing
with another method "CollapsedBorders()".
==========

to

==========
Rename LayoutTable::CollapseBorders() to ShouldCollapseBorders()

The method returns true if the table has "border-collapse: collapse"
style. A better name could be CollapsesBorders() to reflect its
purpose, but both this name and the original name are easily confusing
with another method "CollapsedBorders()".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[Xianzhu, 2017-04-28 17:03:58]

wangxianzhu@chromium.org changed reviewers:
+ wkorman@chromium.org

[wkorman, 2017-04-28 17:56:21]

lgtm

The only other idea I came up with on brief reflection was
"CollapsedBordersEnabled", but ShouldXxx is more consistent with how we name
other things.

[Xianzhu, 2017-05-01 19:07:17]

The CQ bit was checked by wangxianzhu@chromium.org

[commit-bot: I haz the power, 2017-05-01 19:08:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 19:18:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 19:19:01]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Xianzhu, 2017-05-01 19:27:16]

The CQ bit was checked by wangxianzhu@chromium.org

[Xianzhu, 2017-05-01 19:27:17]

The patchset sent to the CQ was uploaded after l-g-t-m from wkorman@chromium.org
Link to the patchset: https://codereview.chromium.org/2850633003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-01 19:27:40]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 22:08:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493666836758680,
"parent_rev": "cdd685a13fa2abf0fee9f2041cffcccaaf3477e4", "commit_rev":
"05f315fbcdb64a90b96d4fee27741100e2bcdbb4"}

[commit-bot: I haz the power, 2017-05-01 22:08:50]

Description was changed from

==========
Rename LayoutTable::CollapseBorders() to ShouldCollapseBorders()

The method returns true if the table has "border-collapse: collapse"
style. A better name could be CollapsesBorders() to reflect its
purpose, but both this name and the original name are easily confusing
with another method "CollapsedBorders()".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Rename LayoutTable::CollapseBorders() to ShouldCollapseBorders()

The method returns true if the table has "border-collapse: collapse"
style. A better name could be CollapsesBorders() to reflect its
purpose, but both this name and the original name are easily confusing
with another method "CollapsedBorders()".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2850633003
Cr-Commit-Position: refs/heads/master@{#468443}
Committed:
https://chromium.googlesource.com/chromium/src/+/05f315fbcdb64a90b96d4fee2774...
==========

[commit-bot: I haz the power, 2017-05-01 22:08:51]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/05f315fbcdb64a90b96d4fee2774...