third_party/WebKit/Source/core/layout/LayoutTableRow.cpp - Issue 2850633003: Rename LayoutTable::CollapseBorders() to ShouldCollapseBorders()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

Issue 2850633003: Rename LayoutTable::CollapseBorders() to ShouldCollapseBorders() (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

index 7df3acb58c0067948b552dde43cfbebcf045faae..a2b8f5d5a253ddc953d75c7d6270bb10bb158fa0 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTableRow.cpp

@@ -170,7 +170,7 @@ void LayoutTableRow::AddChild(LayoutObject* child, LayoutObject* before_child) {

// When borders collapse, adding a cell can affect the the width of

// neighboring cells.

LayoutTable* enclosing_table = Table();

- if (enclosing_table && enclosing_table->CollapseBorders()) {

+ if (enclosing_table && enclosing_table->ShouldCollapseBorders()) {

enclosing_table->InvalidateCollapsedBorders();

if (LayoutTableCell* previous_cell = cell->PreviousCell())

previous_cell->SetNeedsLayoutAndPrefWidthsRecalc(