Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 2850483003: Enters VrShell if WebVR page does not request present in vrdisplayactivate handler. (Closed)

Created:
3 years, 7 months ago by tiborg
Modified:
3 years, 7 months ago
Reviewers:
mthiesse
CC:
chromium-reviews, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enters VrShell if WebVR page doesn not request present in vrdisplayactivate handler. - Browser goes into VR Browsing Mode when the user inserts the phone into the headeset. - Browser will then automatically go into presentation mode if page requests present in onvrdisplayactivate handler. - In a follow-up CL, browser should tentatively go into presentation mode if page is listening for onvrdisplayactivate (and exit presentation if page does not request present). BUG=703315 Review-Url: https://codereview.chromium.org/2850483003 Cr-Commit-Position: refs/heads/master@{#467714} Committed: https://chromium.googlesource.com/chromium/src/+/bd3a5c1291959abcb9b70381e63156d6ae234e5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 2 chunks +4 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
tiborg
PTAL
3 years, 7 months ago (2017-04-27 15:40:01 UTC) #2
mthiesse
lgtm, but we need to get the followup in soon. This is better than the ...
3 years, 7 months ago (2017-04-27 15:50:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850483003/1
3 years, 7 months ago (2017-04-27 16:00:22 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 16:58:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bd3a5c1291959abcb9b70381e631...

Powered by Google App Engine
This is Rietveld 408576698