Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1573)

Issue 2844833005: Tentatively goes into WebVR presentation mode if page listens to vrdisplayactivate. (Closed)

Created:
3 years, 7 months ago by tiborg
Modified:
3 years, 7 months ago
Reviewers:
mthiesse, bajones, estark
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, blink-reviews, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, feature-vr-reviews_chromium.org, agrieve+watch_chromium.org, haraken, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Tentatively goes into WebVR presentation mode if page listens to vrdisplayactivate. - When the user puts the phone into the headset VR browser goes into WebVR presentation mode if the page listens to vrdisplayactivate. - If the page does not request presentation in the vrdisplayactivate handler browser exits presentation and goes into VrShell. BUG=703315 Review-Url: https://codereview.chromium.org/2844833005 Cr-Commit-Position: refs/heads/master@{#468526} Committed: https://chromium.googlesource.com/chromium/src/+/740768575325237705b0249460683fcf692bbd1e

Patch Set 1 #

Patch Set 2 : Fixed device unit tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -18 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java View 4 chunks +11 lines, -6 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/android/vr_shell/vr_shell_delegate.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M device/vr/test/fake_vr_display_impl_client.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M device/vr/vr_device.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/vr/vr_device.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M device/vr/vr_display_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M device/vr/vr_display_impl.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M device/vr/vr_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.h View 2 chunks +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/vr/VRDisplay.cpp View 3 chunks +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (8 generated)
tiborg
PTAL
3 years, 7 months ago (2017-04-27 15:55:49 UTC) #2
mthiesse
lgtm!
3 years, 7 months ago (2017-04-27 16:01:20 UTC) #3
tiborg
Hi Emily, Please take a look at vr_service.mojom. Thank you! Cheers, Tibor
3 years, 7 months ago (2017-04-27 16:17:36 UTC) #5
bajones
LGTM
3 years, 7 months ago (2017-04-27 16:58:37 UTC) #6
estark
mojom lgtm
3 years, 7 months ago (2017-05-01 18:13:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844833005/1
3 years, 7 months ago (2017-05-01 18:25:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/283267)
3 years, 7 months ago (2017-05-01 18:50:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844833005/20001
3 years, 7 months ago (2017-05-01 21:14:35 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 01:33:36 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/740768575325237705b024946068...

Powered by Google App Engine
This is Rietveld 408576698