Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2850433002: webkitpy: Change paths in lint-expectations warning messages (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Change paths in lint-test-expectations messages In order to void path_from_webkit_base() in test_expectations.py, this CL change it to path_from_chromium_base(). lint-expectations messages will be changed from: LayoutTests/TestExpectations:3320 Duplicate or ambiguous entry lines LayoutTests/TestExpectations:3319 and LayoutTests/TestExpectations:3320. external/wpt/css/css-display-3/display-contents-computed-style.html to third_party/WebKit/LayoutTests/TestExpectations:3320 Duplicate or ambiguous entry lines third_party/WebKit/LayoutTests/TestExpectations:3319 and third_party/WebKit/LayoutTests/TestExpectations:3320. external/wpt/css/css-display-3/display-contents-computed-style.html BUG=710535 Review-Url: https://codereview.chromium.org/2850433002 Cr-Commit-Position: refs/heads/master@{#467824} Committed: https://chromium.googlesource.com/chromium/src/+/5c25a63a509bfb5b927b11550e42489161f7dd04

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
tkent
jeffcarp@, would you review this please?
3 years, 7 months ago (2017-04-27 08:35:23 UTC) #7
jeffcarp
lgtm
3 years, 7 months ago (2017-04-27 21:26:01 UTC) #9
tkent
3 years, 7 months ago (2017-04-27 23:07:12 UTC) #10
tkent
3 years, 7 months ago (2017-04-27 23:07:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850433002/1
3 years, 7 months ago (2017-04-28 01:43:23 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 01:57:58 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c25a63a509bfb5b927b11550e42...

Powered by Google App Engine
This is Rietveld 408576698