third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py - Issue 2850433002: webkitpy: Change paths in lint-expectations warning messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

Issue 2850433002: webkitpy: Change paths in lint-expectations warning messages (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

index 62c523a3cbf96eb6eb5af9254e5f2f702d3830d3..8328a6331aace34addfbbbb7eea23696965f0d4d 100644

--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

@@ -1097,9 +1097,8 @@ class TestExpectations(object):

def _shorten_filename(self, filename):

finder = WebKitFinder(self._port.host.filesystem)

- # TODO(tkent): Can we use path_from_layout_tests() instead?

- if filename.startswith(finder.path_from_webkit_base()):

- return self._port.host.filesystem.relpath(filename, finder.path_from_webkit_base())

+ if filename.startswith(finder.path_from_chromium_base()):

+ return self._port.host.filesystem.relpath(filename, finder.path_from_chromium_base())

return filename

def _report_warnings(self):

« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py » ('j') | no next file with comments »