DevTools: Promisify Profiler and HeapProfiler domains

DevTools: Promisify Profiler and HeapProfiler domains

Get rid of method callbacks. Return the protocol method result with
a Promise.

There are some limitations for the API:
1. Only the first return parameter of the callback is provided.
2. The error string is not available.

If the caller needs the error string or other return parameters please
use more generic invoke_* version of the protocol method.

Review-Url: https://codereview.chromium.org/2850333002
Cr-Commit-Position: refs/heads/master@{#468842}
Committed: https://chromium.googlesource.com/chromium/src/+/4b71ab4d94952c27398fb398aaf12dcd3008a4cc

[alph, 2017-05-02 01:17:13]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[dgozman, 2017-05-02 20:03:42]

So if I add a second output parameter, it continues to compile and work? Sounds
nice.

https://codereview.chromium.org/2850333002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js
(right):

https://codereview.chromium.org/2850333002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js:634:
return userCallback ? userCallback.apply(null, args) : args[1] || null;
Everyone was checking for error, not for null/undefined:

: (args[0] ? null : args[1])

https://codereview.chromium.org/2850333002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js
(right):

https://codereview.chromium.org/2850333002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js:89: return
this._heapProfilerAgent.invoke_takeHeapSnapshot({reportProgress:
reportProgress})
Can we do something here? Do you have an idea how many methods need this
boolean? Maybe even these ones don't?

[alph, 2017-05-02 22:48:06]

ptal

https://codereview.chromium.org/2850333002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js
(right):

https://codereview.chromium.org/2850333002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/protocol/InspectorBackend.js:634:
return userCallback ? userCallback.apply(null, args) : args[1] || null;
On 2017/05/02 20:03:41, dgozman wrote:
> Everyone was checking for error, not for null/undefined:
> 
> : (args[0] ? null : args[1])

Done.

https://codereview.chromium.org/2850333002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js
(right):

https://codereview.chromium.org/2850333002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js:89: return
this._heapProfilerAgent.invoke_takeHeapSnapshot({reportProgress:
reportProgress})
On 2017/05/02 20:03:41, dgozman wrote:
> Can we do something here? Do you have an idea how many methods need this
> boolean? Maybe even these ones don't?

Done.

[alph, 2017-05-02 22:48:35]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 22:49:16]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2017-05-02 23:21:34]

lgtm

[commit-bot: I haz the power, 2017-05-03 00:29:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:29:58]

Dry run: This issue passed the CQ dry run.

[alph, 2017-05-03 00:32:14]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-05-03 00:33:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 00:39:11]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493771534472400,
"parent_rev": "8faac4375f1b376408ebea82677278a745a7694d", "commit_rev":
"4b71ab4d94952c27398fb398aaf12dcd3008a4cc"}

[commit-bot: I haz the power, 2017-05-03 00:39:19]

Description was changed from

==========
DevTools: Promisify Profiler and HeapProfiler domains

Get rid of method callbacks. Return the protocol method result with
a Promise.

There are some limitations for the API:
1. Only the first return parameter of the callback is provided.
2. The error string is not available.

If the caller needs the error string or other return parameters please
use more generic invoke_* version of the protocol method.
==========

to

==========
DevTools: Promisify Profiler and HeapProfiler domains

Get rid of method callbacks. Return the protocol method result with
a Promise.

There are some limitations for the API:
1. Only the first return parameter of the callback is provided.
2. The error string is not available.

If the caller needs the error string or other return parameters please
use more generic invoke_* version of the protocol method.

Review-Url: https://codereview.chromium.org/2850333002
Cr-Commit-Position: refs/heads/master@{#468842}
Committed:
https://chromium.googlesource.com/chromium/src/+/4b71ab4d94952c27398fb398aaf1...
==========

[commit-bot: I haz the power, 2017-05-03 00:39:20]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4b71ab4d94952c27398fb398aaf1...