third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html - Issue 2850333002: DevTools: Promisify Profiler and HeapProfiler domains

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

Issue 2850333002: DevTools: Promisify Profiler and HeapProfiler domains (Closed)

Patch Set: addressing comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/inspector/network-test.js ('k') | third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-loader.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

diff --git a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

index 79d56ab06d3d19b7bcab324e18e21a164db072e7..ed8e3283d37b76ddc42c6bf2529a39ff4b159b4c 100644

--- a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

+++ b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-inspect-dom-wrapper.html

@@ -16,7 +16,7 @@ function test()

var heapProfileType = Profiler.ProfileTypeRegistry.instance.heapSnapshotProfileType;

heapProfileType.addEventListener(Profiler.HeapSnapshotProfileType.SnapshotReceived, finishHeapSnapshot);

InspectorTest.addSniffer(heapProfileType, "_snapshotReceived", snapshotReceived);

- heapProfileType._takeHeapSnapshot(function() {});

+ heapProfileType._takeHeapSnapshot();

function finishHeapSnapshot(uid)

{