Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2850273002: Enforce that mock host resolver isn't modified in a test body. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Enforce that mock host resolver isn't modified in a test body. This will be incompatible with a network process since we want to synchronize mock rules with it before the test starts. BUG=713847 Review-Url: https://codereview.chromium.org/2850273002 Cr-Commit-Position: refs/heads/master@{#468686} Committed: https://chromium.googlesource.com/chromium/src/+/7267b7d974901c85735a7d3bd3fff186f1f71948

Patch Set 1 #

Patch Set 2 : reupload #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M content/public/test/browser_test_base.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
jam
3 years, 7 months ago (2017-05-02 15:49:46 UTC) #10
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-02 16:25:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850273002/20001
3 years, 7 months ago (2017-05-02 16:55:13 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 17:00:31 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7267b7d974901c85735a7d3bd3ff...

Powered by Google App Engine
This is Rietveld 408576698