Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2503)

Unified Diff: content/public/test/browser_test_base.cc

Issue 2850273002: Enforce that mock host resolver isn't modified in a test body. (Closed)
Patch Set: reupload Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/browser_test_base.cc
diff --git a/content/public/test/browser_test_base.cc b/content/public/test/browser_test_base.cc
index 189218257e1750f9c3f8327103ee0881d28391c4..d9e976e15f6bd23946a86a8676e7920e8c702cea 100644
--- a/content/public/test/browser_test_base.cc
+++ b/content/public/test/browser_test_base.cc
@@ -381,9 +381,7 @@ void BrowserTestBase::InitializeNetworkProcess() {
// the host rules (when not using the network service).
if (network_service ||
std::string(test_info->name()) != "ProcessTransferAfterError") {
- // TODO(jam): enable this once all access to host_resolver() is in
- // SetUpOnMainThread or before. http://crbug.com/713847
- // host_resolver()->DisableModifications();
+ host_resolver()->DisableModifications();
}
if (!network_service)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698