Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2850173003: Move LengthSizes border-*-radius out of BorderData (Closed)

Created:
3 years, 7 months ago by nainar
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10, shend
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Move LengthSizes border-*-radius out of BorderData In StyleSurroundData, the border longhand properties are stored in a single BorderData. This makes it difficult to generate because the generator assumes that properties don't share storage. This patch splits the LenthSize objects maintaining the border-*-radius into individual properties stored directly on the surround group instead. Generated files diff here: https://gist.github.com/nainar/3192118aab7de3831137a4ae2cc73958/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2850173003 Cr-Commit-Position: refs/heads/master@{#468907} Committed: https://chromium.googlesource.com/chromium/src/+/9c87e10d5fb83551260b6c48de694eb7946b98a8

Patch Set 1 #

Total comments: 3

Patch Set 2 : nit and rebase #

Patch Set 3 : Make sure to call RadiiEqual in all places in the code #

Patch Set 4 : Make sure to call RadiiEqual in all places in the code #

Total comments: 2

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -108 lines) Patch
M third_party/WebKit/Source/build/scripts/make_computed_style_base.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSProperties.json5 View 1 2 chunks +16 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 2 3 1 chunk +9 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableBoxComponent.cpp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/BorderData.h View 6 chunks +3 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/style/CachedUAStyle.h View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 2 3 4 3 chunks +18 lines, -50 lines 0 comments Download
M third_party/WebKit/Source/core/style/ComputedStyle.cpp View 1 2 3 4 3 chunks +20 lines, -17 lines 0 comments Download

Messages

Total messages: 32 (24 generated)
nainar
shend@, PTAL? Thanks!
3 years, 7 months ago (2017-05-01 23:52:12 UTC) #5
shend
lgtm after comments https://codereview.chromium.org/2850173003/diff/1/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/2850173003/diff/1/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp#newcode1960 third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1960: !(cached_ua_style->top_left_ == Hmm, should this be ...
3 years, 7 months ago (2017-05-02 00:01:46 UTC) #6
nainar
https://codereview.chromium.org/2850173003/diff/1/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/2850173003/diff/1/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp#newcode1960 third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1960: !(cached_ua_style->top_left_ == On 2017/05/02 at 00:01:45, shend wrote: > ...
3 years, 7 months ago (2017-05-02 00:42:33 UTC) #9
nainar
Made the changes shend@ suggested. meade@ PTAL? Thanks! https://codereview.chromium.org/2850173003/diff/1/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/2850173003/diff/1/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp#newcode1960 third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1960: !(cached_ua_style->top_left_ ...
3 years, 7 months ago (2017-05-02 00:49:52 UTC) #12
meade_UTC10
lgtm https://codereview.chromium.org/2850173003/diff/60001/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/2850173003/diff/60001/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp#newcode1967 third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1967: state.Style()->BorderBottomRightRadius())); Lol the != operator doesn't exist? I ...
3 years, 7 months ago (2017-05-03 03:22:30 UTC) #21
nainar
https://codereview.chromium.org/2850173003/diff/60001/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp File third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp (right): https://codereview.chromium.org/2850173003/diff/60001/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp#newcode1967 third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp:1967: state.Style()->BorderBottomRightRadius())); On 2017/05/03 at 03:22:30, meade_UTC10 wrote: > Lol ...
3 years, 7 months ago (2017-05-03 04:25:47 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850173003/80001
3 years, 7 months ago (2017-05-03 06:35:13 UTC) #29
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 06:40:08 UTC) #32
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/9c87e10d5fb83551260b6c48de69...

Powered by Google App Engine
This is Rietveld 408576698