Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2850173003: Move LengthSizes border-*-radius out of BorderData (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index bda342f8f6f20f026bcd18f3065d44959dbc9161..3f70dc8bb209a6a18a8c274b9a9a9d11816e7f20 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -560,43 +560,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
SET_BORDERVALUE_COLOR(surround_data_, border_.bottom_, v);
}
- // Border radius properties.
- static LengthSize InitialBorderRadius() {
- return LengthSize(Length(0, kFixed), Length(0, kFixed));
- }
-
- // border-top-left-radius (aka -webkit-border-top-left-radius)
- const LengthSize& BorderTopLeftRadius() const {
- return surround_data_->border_.TopLeft();
- }
- void SetBorderTopLeftRadius(const LengthSize& s) {
- SET_VAR(surround_data_, border_.top_left_, s);
- }
-
- // border-top-right-radius (aka -webkit-border-top-right-radius)
- const LengthSize& BorderTopRightRadius() const {
- return surround_data_->border_.TopRight();
- }
- void SetBorderTopRightRadius(const LengthSize& s) {
- SET_VAR(surround_data_, border_.top_right_, s);
- }
-
- // border-bottom-left-radius (aka -webkit-border-bottom-left-radius)
- const LengthSize& BorderBottomLeftRadius() const {
- return surround_data_->border_.BottomLeft();
- }
- void SetBorderBottomLeftRadius(const LengthSize& s) {
- SET_VAR(surround_data_, border_.bottom_left_, s);
- }
-
- // border-bottom-right-radius (aka -webkit-border-bottom-right-radius)
- const LengthSize& BorderBottomRightRadius() const {
- return surround_data_->border_.BottomRight();
- }
- void SetBorderBottomRightRadius(const LengthSize& s) {
- SET_VAR(surround_data_, border_.bottom_right_, s);
- }
-
// box-shadow (aka -webkit-box-shadow)
static ShadowList* InitialBoxShadow() { return 0; }
ShadowList* BoxShadow() const {
@@ -2885,11 +2848,28 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
bool HasBorderFill() const { return Border().HasBorderFill(); }
bool HasBorder() const { return Border().HasBorder(); }
bool HasBorderDecoration() const { return HasBorder() || HasBorderFill(); }
- bool HasBorderRadius() const { return Border().HasBorderRadius(); }
+ bool HasBorderRadius() const {
+ if (!BorderTopLeftRadius().Width().IsZero())
+ return true;
+ if (!BorderTopRightRadius().Width().IsZero())
+ return true;
+ if (!BorderBottomLeftRadius().Width().IsZero())
+ return true;
+ if (!BorderBottomRightRadius().Width().IsZero())
+ return true;
+ return false;
+ }
bool HasBorderColorReferencingCurrentColor() const {
return Border().HasBorderColorReferencingCurrentColor();
}
+ bool RadiiEqual(const ComputedStyle& o) const {
+ return BorderTopLeftRadius() == o.BorderTopLeftRadius() &&
+ BorderTopRightRadius() == o.BorderTopRightRadius() &&
+ BorderBottomLeftRadius() == o.BorderBottomLeftRadius() &&
+ BorderBottomRightRadius() == o.BorderBottomRightRadius();
+ }
+
void ResetBorder() {
ResetBorderImage();
ResetBorderTop();
@@ -2916,18 +2896,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
void ResetBorderImage() {
SET_VAR(surround_data_, border_.image_, NinePieceImage());
}
- void ResetBorderTopLeftRadius() {
- SET_VAR(surround_data_, border_.top_left_, InitialBorderRadius());
- }
- void ResetBorderTopRightRadius() {
- SET_VAR(surround_data_, border_.top_right_, InitialBorderRadius());
- }
- void ResetBorderBottomLeftRadius() {
- SET_VAR(surround_data_, border_.bottom_left_, InitialBorderRadius());
- }
- void ResetBorderBottomRightRadius() {
- SET_VAR(surround_data_, border_.bottom_right_, InitialBorderRadius());
- }
void SetBorderRadius(const LengthSize& s) {
SetBorderTopLeftRadius(s);
« no previous file with comments | « third_party/WebKit/Source/core/style/CachedUAStyle.h ('k') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698