Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java

Issue 2850163002: Fix main intent metrics when zero tabs present. (Closed)
Patch Set: Add findbugs suppression in code only used for testing Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetrics.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
index 91cc66eddf90ee53ac155eb8429d30bb1edf095e..332cda5e8d6b6dc446768d5164cf8739b0334d4f 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java
@@ -878,7 +878,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
// it will trigger the notification that tab restore is complete which is needed by
// other parts of Chrome such as sync.
boolean activeTabBeingRestored = !mIntentWithEffect;
+ mMainIntentMetrics.setIgnoreEvents(true);
mTabModelSelectorImpl.restoreTabs(activeTabBeingRestored);
+ mMainIntentMetrics.setIgnoreEvents(false);
// Only create an initial tab if no tabs were restored and no intent was handled.
// Also, check whether the active tab was supposed to be restored and that the total
@@ -893,8 +895,9 @@ public class ChromeTabbedActivity extends ChromeActivity implements OverviewMode
new Runnable() {
@Override
public void run() {
- mMainIntentMetrics.ignorePendingAddTab();
+ mMainIntentMetrics.setIgnoreEvents(true);
createInitialTab();
+ mMainIntentMetrics.setIgnoreEvents(false);
}
}, INITIAL_TAB_CREATION_TIMEOUT_MS);
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/metrics/MainIntentBehaviorMetrics.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698