Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2850123002: M58: arc: Set migration success notification pref. (Closed)

Created:
3 years, 7 months ago by kinaba
Modified:
3 years, 7 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, alemate+watch_chromium.org, oshima+watch_chromium.org, hidehiko+watch_chromium.org, achuith+watch_chromium.org, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Target Ref:
refs/branch-heads/3029
Project:
chromium
Visibility:
Public.

Description

arc: M58: Set migration success notification pref. The code for M59 or above expects the flag to be already set if the user started using the new filesystem from the very beginning they started using the device. M58 needs to set it. Cherry-pick from the following four changes 1. crrev.com/2788383003 (Only pref name addition) 2. crrev.com/2813633002 (Only BUILD.gn addition) 3. crrev.com/2808353008 (UpdateArcFileSystemCompatibilityPrefIfNeeded) 4. crrev.com/2828213002 (ShowArcMigrationSuccessNotificationIfNeeded) with unneeded part (disabling ARC or showing notification based on the flag) removed. BUG=716976 TEST=Manually checked the pref value is set to 2 on M58 Reef. R=hidehiko@chromium.org Review-Url: https://codereview.chromium.org/2850123002 . Cr-Commit-Position: refs/branch-heads/3029@{#788} Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471} Committed: https://chromium.googlesource.com/chromium/src/+/47ed318163625a82be7c028f3de0d87a012af4ea

Patch Set 1 #

Patch Set 2 : Fix some comment for M58 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -1 line) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/arc/arc_migration_guide_notification.h View 1 1 chunk +19 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/arc/arc_migration_guide_notification.cc View 1 chunk +37 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_util.h View 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_util.cc View 4 chunks +75 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 3 chunks +10 lines, -1 line 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
kinaba
I'm thinking about requesting merge of this change. Hidehiko, could you mind taking a look? ...
3 years, 7 months ago (2017-05-01 05:59:06 UTC) #3
hidehiko
LGTM. Please consult with TPM if this is ok to be merged to release branch.
3 years, 7 months ago (2017-05-01 06:17:03 UTC) #4
kinaba
3 years, 7 months ago (2017-05-01 22:11:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
47ed318163625a82be7c028f3de0d87a012af4ea.

Powered by Google App Engine
This is Rietveld 408576698