arc: Notification for guiding the user to filesystem migration.

arc: Notification for guiding the user to filesystem migration.

When ARC is temporarily disabled due to filesystem incompatibility,
we want to keep the launcher/tray icons for ARC apps displayed,
and when the icons are clicked we want to guide the user for proper
reconfiguration step (i.e., sign back in and complete migration.)

This CL implements the latter "show notificaiton" part.
No actual code should hit this notification yet--after this change
I'll change several conditions in the app list code to make them alive.

BUG=699850

[kinaba, 2017-04-10 13:50:41]

kinaba@chromium.org changed reviewers:
+ hidehiko@chromium.org, khmel@chromium.org

[kinaba, 2017-04-10 13:50:42]

PTAL.
hidehiko: as the OWNER
khmel: as the ARC app list expert.

This is to respond for UX request to keep ARC app icons still when they
are disabled for filesystem incompatibility.

This CL is meant to be on top of
https://codereview.chromium.org/2806443002/,
and to be followed be the next coming (not yet completed) CL to enable the ARC
app icons based on IsArcAllowedInAppListForProfile.

[hidehiko, 2017-04-10 14:14:09]

LGTM with minor comments.
R+=xiyuan@ for c/b/ui/app_list OWNER. Could you take a look?

https://codereview.chromium.org/2813633002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2813633002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6560: To use Android apps, change & update
your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>.
Maybe s/change/charge/ ?

https://codereview.chromium.org/2813633002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_migration_guide_notification.cc (right):

https://codereview.chromium.org/2813633002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_migration_guide_notification.cc:32:
ArcMigrationGuideNotificationDelegate() {}
nit: Please s/{}/= default;/. Ditto for dtor.

[hidehiko, 2017-04-10 14:14:43]

hidehiko@chromium.org changed reviewers:
+ xiyuan@chromium.org

[hidehiko, 2017-04-10 14:14:43]

Oops, misoperation..., sorry. Added xiyuan@ actually.

[kinaba, 2017-04-10 14:20:06]

The CQ bit was checked by kinaba@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 14:20:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kinaba, 2017-04-10 14:31:01]

https://codereview.chromium.org/2813633002/diff/1/chrome/app/chromeos_strings...
File chrome/app/chromeos_strings.grdp (right):

https://codereview.chromium.org/2813633002/diff/1/chrome/app/chromeos_strings...
chrome/app/chromeos_strings.grdp:6560: To use Android apps, change & update
your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>.
On 2017/04/10 14:14:09, hidehiko wrote:
> Maybe s/change/charge/ ?

Buy a new Chromebook!
Done :)

https://codereview.chromium.org/2813633002/diff/1/chrome/browser/chromeos/arc...
File chrome/browser/chromeos/arc/arc_migration_guide_notification.cc (right):

https://codereview.chromium.org/2813633002/diff/1/chrome/browser/chromeos/arc...
chrome/browser/chromeos/arc/arc_migration_guide_notification.cc:32:
ArcMigrationGuideNotificationDelegate() {}
On 2017/04/10 14:14:09, hidehiko wrote:
> nit: Please s/{}/= default;/. Ditto for dtor.

Done.

[commit-bot: I haz the power, 2017-04-10 16:29:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 16:29:52]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2017-04-10 17:39:25]

lgtm

[khmel, 2017-04-10 19:10:10]

LGTM (Assuming this is preparation for activating this functionality later)

https://codereview.chromium.org/2813633002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_migration_guide_notification.cc (right):

https://codereview.chromium.org/2813633002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_migration_guide_notification.cc:66: //
TODO(kinaba): Change message for low-battery case.
nit: probably bug id sounds better here once this looks important from UI
perspective. Same below

https://codereview.chromium.org/2813633002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_migration_guide_notification.h (right):

https://codereview.chromium.org/2813633002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_migration_guide_notification.h:12: // Show a
notification for guiding the user for file system migration.
nit: Shows

[kinaba, 2017-04-11 00:58:39]

The CQ bit was checked by kinaba@chromium.org to run a CQ dry run

[kinaba, 2017-04-11 00:59:20]

Thanks for the comments!

https://codereview.chromium.org/2813633002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_migration_guide_notification.cc (right):

https://codereview.chromium.org/2813633002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_migration_guide_notification.cc:66: //
TODO(kinaba): Change message for low-battery case.
On 2017/04/10 19:10:10, khmel wrote:
> nit: probably bug id sounds better here once this looks important from UI
> perspective. Same below

Done.

https://codereview.chromium.org/2813633002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/arc/arc_migration_guide_notification.h (right):

https://codereview.chromium.org/2813633002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/arc/arc_migration_guide_notification.h:12: // Show a
notification for guiding the user for file system migration.
On 2017/04/10 19:10:10, khmel wrote:
> nit: Shows

Done.

[commit-bot: I haz the power, 2017-04-11 00:59:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 02:11:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 02:11:37]

Dry run: This issue passed the CQ dry run.

[kinaba, 2017-04-11 02:12:01]

The CQ bit was checked by kinaba@chromium.org

[kinaba, 2017-04-11 02:12:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
hidehiko@chromium.org, xiyuan@chromium.org, khmel@chromium.org
Link to the patchset: https://codereview.chromium.org/2813633002/#ps40001
(title: "Fix for khmel@'s comments.")

[commit-bot: I haz the power, 2017-04-11 02:12:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-11 02:23:32]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491876721388510,
"parent_rev": "f18b4bfa08f94f62114ca49a3125fc4edbc06bf2", "commit_rev":
"6cb1c9a147eff32e3bacec76f0700c6a401c44d2"}

[commit-bot: I haz the power, 2017-04-11 02:29:49]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1491876721388510,
"parent_rev": "6cb1c9a147eff32e3bacec76f0700c6a401c44d2", "commit_rev":
"02f7415f759e84f4ecb58a3376f1c436ce60303e"}

[commit-bot: I haz the power, 2017-04-11 03:09:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-11 03:09:08]

Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

[kinaba, 2017-04-11 03:11:26]

Description was changed from

==========
arc: Notification for guiding the user to filesystem migration.

When ARC is temporarily disabled due to filesystem incompatibility,
we want to keep the launcher/tray icons for ARC apps displayed,
and when the icons are clicked we want to guide the user for proper
reconfiguration step (i.e., sign back in and complete migration.)

This CL implements the latter "show notificaiton" part.
No actual code should hit this notification yet--after this change
I'll change several conditions in the app list code to make them alive.

BUG=699850
==========

to

==========
arc: Notification for guiding the user to filesystem migration.

When ARC is temporarily disabled due to filesystem incompatibility,
we want to keep the launcher/tray icons for ARC apps displayed,
and when the icons are clicked we want to guide the user for proper
reconfiguration step (i.e., sign back in and complete migration.)

This CL implements the latter "show notificaiton" part.
No actual code should hit this notification yet--after this change
I'll change several conditions in the app list code to make them alive.

BUG=699850
==========

[kinaba, 2017-04-11 03:13:08]

On 2017/04/11 03:09:08, commit-bot: I haz the power wrote:
> Prior attempt to commit was detected, but we were not able to check whether
the
> issue was successfully committed. Please check Git history manually and
re-check
> CQ or close this issue as needed.

Git log says it has landed. Closing