third_party/WebKit/Source/web/WebViewFrameWidget.cpp - Issue 2850113002: Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewFrameWidget.cpp

Issue 2850113002: Move WebViewFrameWidget to use WebViewBase rather than WebViewImpl. (Closed)

Patch Set: Fix code review comments. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/WebViewFrameWidget.cpp

diff --git a/third_party/WebKit/Source/web/WebViewFrameWidget.cpp b/third_party/WebKit/Source/web/WebViewFrameWidget.cpp

index e62eba81570ca60b5ed4b24f2974aedba8bd3d58..0690f2af085346f29b58929942f462a5f7929338 100644

--- a/third_party/WebKit/Source/web/WebViewFrameWidget.cpp

+++ b/third_party/WebKit/Source/web/WebViewFrameWidget.cpp

@@ -4,14 +4,15 @@

#include "web/WebViewFrameWidget.h"

+#include "core/exported/WebViewBase.h"

+#include "core/layout/HitTestResult.h"

#include "web/WebInputMethodControllerImpl.h"

#include "web/WebLocalFrameImpl.h"

-#include "web/WebViewImpl.h"

namespace blink {

WebViewFrameWidget::WebViewFrameWidget(WebWidgetClient& client,

- WebViewImpl& web_view,

+ WebViewBase& web_view,

WebLocalFrameImpl& main_frame)

: client_(&client), web_view_(&web_view), main_frame_(&main_frame) {

main_frame_->SetFrameWidget(this);