Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2850093003: Simplify base::Timer implementation

Created:
3 years, 7 months ago by tzik
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, danakj+watch_chromium.org, chirantan+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify base::Timer implementation This CL simplifies base::Timer family by: - Use default parameter to remove constructor overloads. - Move BaseTimerMethodPointer::Start to Timer, so that we can remove entire BaseTimerMethodPointer. - Converts Timer at DelayedTimer's protected parent to a private member of DelayedTimer. BUG=

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -77 lines) Patch
M base/timer/timer.h View 1 4 chunks +34 lines, -68 lines 0 comments Download
M base/timer/timer.cc View 2 chunks +0 lines, -9 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (7 generated)
tzik
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-01 08:56:03 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850093003/1
3 years, 7 months ago (2017-05-01 08:56:21 UTC) #2
tzik
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-01 09:14:48 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850093003/20001
3 years, 7 months ago (2017-05-01 09:15:00 UTC) #4
tzik
Description was changed from ========== Simplify base::Timer implementation BUG= ========== to ========== Simplify base::Timer implementation ...
3 years, 7 months ago (2017-05-01 09:44:01 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-01 11:27:03 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 11:27:03 UTC) #7
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698