Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2837863004: Use base::OneShotTimer instead of base::Timer(false, false)

Created:
3 years, 8 months ago by tzik
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, vmpstr+watch_chromium.org, posciak+watch_chromium.org, chfremer+watch_chromium.org, oka+watch_chromium.org, bnc+watch_chromium.org, fukino+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, jlklein+watch-tether_chromium.org, tengs+watch-tether_chromium.org, jam, net-reviews_chromium.org, jhawkins+watch-tether_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, xjz+watch_chromium.org, lesliewatkins+watch-tether_chromium.org, khorimoto+watch-tether_chromium.org, chromoting-reviews_chromium.org, yamaguchi+watch_chromium.org, hansberry+watch-tether_chromium.org, feature-media-reviews_chromium.org, chirantan+watch_chromium.org, sync-reviews_chromium.org, tfarina, danakj+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use base::OneShotTimer instead of base::Timer(false, false) BUG=

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -50 lines) Patch
M base/timer/timer_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/component_updater/timer.h View 1 chunk +1 line, -1 line 0 comments Download
M components/component_updater/timer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/cryptauth/sync_scheduler_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/domain_reliability/util.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/drive/file_write_watcher.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M components/error_page/renderer/net_error_helper_core.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M components/sync/engine/net/http_bridge.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/sync/model_impl/attachments/task_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/capture/web_contents_video_capture_device_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/request_queue.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/request_queue_impl.h View 1 chunk +1 line, -3 lines 0 comments Download
M media/base/test_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/network_throttle_manager_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M net/base/network_throttle_manager_impl.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/dns/mdns_client_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M net/http/bidirectional_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/http/bidirectional_stream_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_stream.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_stream_create_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/backoff_timer.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/mouse_shape_pump.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/mouse_shape_pump.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/security_key/security_key_socket.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/authenticator_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/capture_scheduler.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/ssl_hmac_channel_authenticator_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/overlay_scroll_bar.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (8 generated)
tzik
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
3 years, 8 months ago (2017-04-25 04:29:37 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837863004/1
3 years, 8 months ago (2017-04-25 04:30:05 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 8 months ago (2017-04-25 04:33:37 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/254560) cast_shell_android on ...
3 years, 8 months ago (2017-04-25 04:33:38 UTC) #4
tzik
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-01 07:58:58 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2837863004/20001
3 years, 7 months ago (2017-05-01 07:59:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-01 10:10:42 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 10:10:43 UTC) #8 
Dry run: This issue passed the CQ dry run.

Powered by Google App Engine
This is Rietveld 408576698