Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: components/autofill/core/browser/form_structure.cc

Issue 2849753002: Logs all reasons card upload was not offered in UKM and UMA. (Closed)
Patch Set: Formatting fix. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure.cc
diff --git a/components/autofill/core/browser/form_structure.cc b/components/autofill/core/browser/form_structure.cc
index 4695b65b4d228606da0233da13dbb5dcae6d6e53..a9abb8dda79b347120afc23b37172240c64c6dea 100644
--- a/components/autofill/core/browser/form_structure.cc
+++ b/components/autofill/core/browser/form_structure.cc
@@ -378,24 +378,26 @@ void FormStructure::DetermineHeuristicTypes(ukm::UkmService* ukm_service) {
UpdateAutofillCount();
IdentifySections(has_author_specified_sections_);
- std::vector<AutofillMetrics::DeveloperEngagementMetric> metrics;
+ int developer_engagement_metrics = 0;
if (IsAutofillable()) {
AutofillMetrics::DeveloperEngagementMetric metric =
has_author_specified_types_
? AutofillMetrics::FILLABLE_FORM_PARSED_WITH_TYPE_HINTS
: AutofillMetrics::FILLABLE_FORM_PARSED_WITHOUT_TYPE_HINTS;
- metrics.push_back(metric);
+ developer_engagement_metrics |= 1 << metric;
AutofillMetrics::LogDeveloperEngagementMetric(metric);
}
if (has_author_specified_upi_vpa_hint_) {
AutofillMetrics::LogDeveloperEngagementMetric(
AutofillMetrics::FORM_CONTAINS_UPI_VPA_HINT);
- metrics.push_back(AutofillMetrics::FORM_CONTAINS_UPI_VPA_HINT);
+ developer_engagement_metrics |=
+ 1 << AutofillMetrics::FORM_CONTAINS_UPI_VPA_HINT;
}
- AutofillMetrics::LogDeveloperEngagementUkm(ukm_service, source_url(),
- metrics);
+ if (developer_engagement_metrics)
+ AutofillMetrics::LogDeveloperEngagementUkm(ukm_service, source_url(),
+ developer_engagement_metrics);
AutofillMetrics::LogDetermineHeuristicTypesTiming(
base::TimeTicks::Now() - determine_heuristic_types_start_time);

Powered by Google App Engine
This is Rietveld 408576698