Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: components/autofill/core/browser/autofill_metrics_unittest.cc

Issue 2849753002: Logs all reasons card upload was not offered in UKM and UMA. (Closed)
Patch Set: Formatting fix. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics_unittest.cc
diff --git a/components/autofill/core/browser/autofill_metrics_unittest.cc b/components/autofill/core/browser/autofill_metrics_unittest.cc
index 888adea8308a2a036beef99f62783dc129f060ed..439910120cab9a4f18940e85886d57cc2215b3b8 100644
--- a/components/autofill/core/browser/autofill_metrics_unittest.cc
+++ b/components/autofill/core/browser/autofill_metrics_unittest.cc
@@ -343,10 +343,12 @@ void VerifyDeveloperEngagementUkm(
ASSERT_NE(nullptr, source);
EXPECT_EQ(form.origin, source->url());
- std::vector<std::pair<const char*, int64_t>> expected_metrics;
+ int expected_metric_value = 0;
for (const auto it : expected_metric_values)
- expected_metrics.push_back(
- {internal::kUKMDeveloperEngagementMetricName, it});
+ expected_metric_value |= 1 << it;
+
+ const std::vector<std::pair<const char*, int64_t>> expected_metrics{
+ {internal::kUKMDeveloperEngagementMetricName, expected_metric_value}};
EXPECT_THAT(entry_proto.metrics(),
UnorderedPointwise(CompareMetrics(), expected_metrics));

Powered by Google App Engine
This is Rietveld 408576698