Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2849753002: Logs all reasons card upload was not offered in UKM and UMA. (Closed)
Patch Set: Formatting fix. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index f33d38a07fc62af0568d0067690743434945a50b..9c7e0f312358fb65b0f2ee07fc6904b71d10a3bf 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3629,7 +3629,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Autofill.CardUploadDecision" enum="AutofillCardUploadDecision">
<obsolete>
- Deprecated as of 2/2016, replaced by Autofill.CardUploadDecisionExpanded.
+ Deprecated as of 2/2016, replaced by Autofill.CardUploadDecisionMetric.
</obsolete>
<owner>jdonnelly@chromium.org</owner>
<summary>
@@ -3640,6 +3640,9 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<histogram name="Autofill.CardUploadDecisionExpanded"
enum="AutofillCardUploadDecisionExpanded">
+ <obsolete>
+ Deprecated as of 5/2017, replaced by Autofill.CardUploadDecisionMetric.
+ </obsolete>
<owner>jdonnelly@chromium.org</owner>
<summary>
Whether upload was offered upon detecting a form submission with credit card
@@ -3647,6 +3650,18 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Autofill.CardUploadDecisionMetric"
+ enum="AutofillCardUploadDecisionMetric">
+ <owner>csashi@google.com</owner>
+ <owner>jsaul@google.com</owner>
+ <owner>sebsg@chromium.org</owner>
+ <summary>
+ Whether upload was offered upon detecting a form submission with credit card
+ data, a detailed reason if upload was offered even with some missing fields
+ and detailed reasons if it wasn't.
+ </summary>
+</histogram>
+
<histogram name="AutoFill.CCInfoBarAccepted">
<obsolete>
Deprecated as of 3/2011, replaced by Autofill.CreditCardInfoBar.
@@ -84382,6 +84397,23 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</enum>
<enum name="AutofillCardUploadDecisionExpanded" type="int">
+ <obsolete>
+ Deprecated as of 5/2017, replaced by AutofillCardUploadDecisionMetric.
+ </obsolete>
+ <int value="0" label="Upload offered"/>
+ <int value="1" label="Upload not offered, no CVC detected"/>
+ <int value="2" label="Upload not offered, no address available"/>
+ <int value="3" label="Upload not offered, no name available"/>
+ <int value="4"
+ label="Upload not offered, addresses had conflicting zip codes"/>
+ <int value="5" label="Upload not offered, no zip code available"/>
+ <int value="6" label="Upload not offered, get upload details RPC failed"/>
+ <int value="7"
+ label="Upload not offered, card and/or addresses had conflicting names"/>
+ <int value="8" label="Upload offered, no CVC detected"/>
+</enum>
+
+<enum name="AutofillCardUploadDecisionMetric" type="int">
<int value="0" label="Upload offered"/>
<int value="1" label="Upload not offered, no CVC detected"/>
<int value="2" label="Upload not offered, no address available"/>
@@ -84392,6 +84424,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="6" label="Upload not offered, get upload details RPC failed"/>
<int value="7"
label="Upload not offered, card and/or addresses had conflicting names"/>
+ <int value="8" label="Upload offered, no CVC detected"/>
+ <int value="9" label="Upload not offered"/>
</enum>
<enum name="AutofillCreditCardInfoBar" type="int">

Powered by Google App Engine
This is Rietveld 408576698