Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 2849743003: webkitpy: Remove WebKitFinder.path_to_script() (Closed)

Created:
3 years, 7 months ago by tkent
Modified:
3 years, 7 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

webkitpy: Remove WebKitFinder.path_to_script() It can be replaced with path_from_tools_scripts(). BUG=710535 Review-Url: https://codereview.chromium.org/2849743003 Cr-Commit-Position: refs/heads/master@{#468260} Committed: https://chromium.googlesource.com/chromium/src/+/a89e88eeb2286f54265e801135d8df7a7ffcb08a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -11 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/webkit_finder.py View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/wpt_expectations_updater.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tkent
jeffcarp@, would you review this please?
3 years, 7 months ago (2017-04-28 09:36:03 UTC) #4
jeffcarp
lgtm
3 years, 7 months ago (2017-04-28 22:24:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2849743003/1
3 years, 7 months ago (2017-04-30 22:25:25 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-30 23:41:31 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a89e88eeb2286f54265e801135d8...

Powered by Google App Engine
This is Rietveld 408576698