Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(950)

Side by Side Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py

Issue 2849743003: webkitpy: Remove WebKitFinder.path_to_script() (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2010 Google Inc. All rights reserved. 1 # Copyright (C) 2010 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 859 matching lines...) Expand 10 before | Expand all | Expand 10 after
870 self._filesystem.write_binary_file(baseline_path, data) 870 self._filesystem.write_binary_file(baseline_path, data)
871 871
872 # TODO(qyearsley): Update callers to create a finder and call it instead 872 # TODO(qyearsley): Update callers to create a finder and call it instead
873 # of these next three routines (which should be protected). 873 # of these next three routines (which should be protected).
874 def webkit_base(self): 874 def webkit_base(self):
875 return self._webkit_finder.webkit_base() 875 return self._webkit_finder.webkit_base()
876 876
877 def path_from_chromium_base(self, *comps): 877 def path_from_chromium_base(self, *comps):
878 return self._webkit_finder.path_from_chromium_base(*comps) 878 return self._webkit_finder.path_from_chromium_base(*comps)
879 879
880 def path_to_script(self, script_name):
881 return self._webkit_finder.path_to_script(script_name)
882
883 def layout_tests_dir(self): 880 def layout_tests_dir(self):
884 custom_layout_tests_dir = self.get_option('layout_tests_directory') 881 custom_layout_tests_dir = self.get_option('layout_tests_directory')
885 if custom_layout_tests_dir: 882 if custom_layout_tests_dir:
886 return custom_layout_tests_dir 883 return custom_layout_tests_dir
887 return self._webkit_finder.layout_tests_dir() 884 return self._webkit_finder.layout_tests_dir()
888 885
889 def perf_tests_dir(self): 886 def perf_tests_dir(self):
890 return self._webkit_finder.perf_tests_dir() 887 return self._webkit_finder.perf_tests_dir()
891 888
892 def skipped_layout_tests(self, _): 889 def skipped_layout_tests(self, _):
(...skipping 739 matching lines...) Expand 10 before | Expand all | Expand 10 after
1632 1629
1633 def __init__(self, base, args, reference_args=None): 1630 def __init__(self, base, args, reference_args=None):
1634 self.name = base 1631 self.name = base
1635 self.base = base 1632 self.base = base
1636 self.args = args 1633 self.args = args
1637 self.reference_args = args if reference_args is None else reference_args 1634 self.reference_args = args if reference_args is None else reference_args
1638 self.tests = set() 1635 self.tests = set()
1639 1636
1640 def __repr__(self): 1637 def __repr__(self):
1641 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args) 1638 return "PhysicalTestSuite('%s', '%s', %s, %s)" % (self.name, self.base, self.args, self.reference_args)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698